commit 097497fb7b2466e85d2800991bef92017b044cda
author Alex Schendel <alex.schendel@intel.com> Fri Oct 07 14:37:15 2022 -0700
committer Alex Schendel <alex.schendel@intel.com> Fri Oct 07 15:01:15 2022 -0700
tree 766e55451ae2ae947b62e1654a37a2c86f1d5338
parent 90eb7876b46a361af3b36c09df574178ecc9c39a

Remove ManagedObjectType Dependency

libipmi now has a getManagedObjects() function which obviates the need
to specify a custom type and use a direct dbus yield method call. This
does not change any behavior of the Get or Capture Manufacturing Data
commands. This commit serves to improve readability and remove
unnecessary dependencies.

Tested:
Get Manufacturing Data continues to report MAC Address:
  ipmitool raw 0x30 0xA2 0x00
    01 a4 bf 01 8c c4 94

Change-Id: I128ef0679932bf247c1e9e1e8bd2e870a24e3d16
Signed-off-by: Alex Schendel <alex.schendel@intel.com>

src/manufacturingcommands.cpp

diff --git a/src/manufacturingcommands.cpp b/src/manufacturingcommands.cpp
index 7928943..09b6dab 100644
--- a/src/manufacturingcommands.cpp
+++ b/src/manufacturingcommands.cpp
@@ -902,23 +902,15 @@
 static constexpr const char* factoryEthAddrBaseFileName =
     "/var/sofs/factory-settings/network/mac/eth";
 
-using ObjectType = boost::container::flat_map<
-    std::string, boost::container::flat_map<std::string, DbusVariant>>;
-using ManagedObjectType =
-    boost::container::flat_map<sdbusplus::message::object_path, ObjectType>;
-
-bool findFruDevice(const std::shared_ptr<sdbusplus::asio::connection>& bus,
-                   boost::asio::yield_context& yield, uint64_t& macOffset,
+bool findFruDevice(ipmi::Context::ptr& ctx, uint64_t& macOffset,
                    uint64_t& busNum, uint64_t& address)
 {
-    boost::system::error_code ec;
+    boost::system::error_code ec{};
+    ObjectValueTree obj;
 
     // GetAll the objects under service FruDevice
-    ec = boost::system::errc::make_error_code(boost::system::errc::success);
-    auto obj = bus->yield_method_call<ManagedObjectType>(
-        yield, ec, "xyz.openbmc_project.EntityManager",
-        "/xyz/openbmc_project/inventory", "org.freedesktop.DBus.ObjectManager",
-        "GetManagedObjects");
+    ec = getManagedObjects(ctx, "xyz.openbmc_project.EntityManager",
+                           "/xyz/openbmc_project/inventory", obj);
     if (ec)
     {
         phosphor::logging::log<phosphor::logging::level::ERR>(
@@ -987,7 +979,7 @@
     uint64_t fruBus = 0;
     uint64_t fruAddress = 0;
 
-    if (findFruDevice(ctx->bus, ctx->yield, macOffset, fruBus, fruAddress))
+    if (findFruDevice(ctx, macOffset, fruBus, fruAddress))
     {
         phosphor::logging::log<phosphor::logging::level::INFO>(
             "Found mac fru",
@@ -1032,7 +1024,7 @@
     uint64_t fruBus = 0;
     uint64_t fruAddress = 0;
 
-    if (findFruDevice(ctx->bus, ctx->yield, macOffset, fruBus, fruAddress))
+    if (findFruDevice(ctx, macOffset, fruBus, fruAddress))
     {
         phosphor::logging::log<phosphor::logging::level::INFO>(
             "Found mac fru",