commit 13b0039d21ccb60163d840a3b7c17c19fbad0b4d
author James Feist <james.feist@linux.intel.com> Mon Aug 19 16:16:08 2019 -0700
committer James Feist <james.feist@linux.intel.com> Tue Aug 20 18:30:25 2019 +0000
tree edc8bc526a5fe30b26e2c7c1cc0d73551fce3346
parent b02bf095450c58342a8091cc78dbc54c6328efbb

Start turning on some warnings

This repo needs a lot of help with warnings, start
turning some on slowly.

Change-Id: Icb3cee86829228cd4cbabecc98e43c77cef17223
Signed-off-by: James Feist <james.feist@linux.intel.com>

src/bmccontrolservices.cpp

diff --git a/src/bmccontrolservices.cpp b/src/bmccontrolservices.cpp
index b446886..8386899 100644
--- a/src/bmccontrolservices.cpp
+++ b/src/bmccontrolservices.cpp
@@ -104,6 +104,7 @@
             return !std::get<bool>(it->second);
         }
     }
+    return false;
 }
 
 ipmi::RspType<> setBmcControlServices(boost::asio::yield_context yield,

src/manufacturingcommands.cpp

diff --git a/src/manufacturingcommands.cpp b/src/manufacturingcommands.cpp
index ad38e79..082df1e 100644
--- a/src/manufacturingcommands.cpp
+++ b/src/manufacturingcommands.cpp
@@ -408,7 +408,7 @@
                                    ipmi_data_len_t data_len,
                                    ipmi_context_t context)
 {
-    uint8_t ret = 0;
+    int8_t ret = 0;
     ipmi_ret_t retCode = IPMI_CC_OK;
     SetSmSignalReq* pReq = static_cast<SetSmSignalReq*>(request);
     std::string ledName;