commit 1429d4f1651b0282c1c506b4feb8e7b675fee649
author jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Wed Mar 04 18:20:16 2020 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Thu May 14 04:24:29 2020 +0000
tree 1793dbf77ca61956948bcea1a291e551c0867527
parent 886a48a98aa05f272b1bdd222baebacb38d9957b

oemcommands: Rewriting ipmiUserSetUserName

ipmiUserSetUserName API signature is changed to use string variable.

Tested:
Command: cmdtool.efi 20 c0 5a 64 65 62 75 67 75 73 65 72 0 0 0 0 0 0 0
 30 70 65 6e 42 6d 63 31 0 0 0 0 0 0 0 0 0 0 0 0
Response: User is created successfully
Command: ipmitool user list 1 //User list for channel 1
Response:
ID  Name             Callin  Link Auth  IPMI Msg   Channel Priv Limit
1   root             false   true       true       ADMINISTRATOR
2   debuguser        true    false      false      NO ACCESS
3   user3            true    false      false      NO ACCESS
4   user4            true    false      false      NO ACCESS

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I673b1c35df14672b7efd31f83f006ff59e562d21

src/oemcommands.cpp

diff --git a/src/oemcommands.cpp b/src/oemcommands.cpp
index bd546e2..580bfd5 100644
--- a/src/oemcommands.cpp
+++ b/src/oemcommands.cpp
@@ -1088,9 +1088,10 @@
     PrivAccess privAccess = {0, true, true, true, PRIVILEGE_ADMIN};
 #endif
 
-    if (ipmi::ccSuccess ==
-        ipmiUserSetUserName(ipmiDefaultUserId,
-                            reinterpret_cast<const char*>(userName.data())))
+    const std::string strUserName(
+        reinterpret_cast<const char*>(userName.data()));
+
+    if (ipmi::ccSuccess == ipmiUserSetUserName(ipmiDefaultUserId, strUserName))
     {
         if (ipmi::ccSuccess ==
             ipmiUserSetUserPassword(