commit 2d4a0198e3832ffa1c45b49e151e3ce74704e616
author jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Mon Nov 11 22:12:45 2019 +0000
committer mutyalax.jayaprakash <mutyalax.jayaprakash@intel.com> Mon Dec 02 16:23:10 2019 +0000
tree d221436dd9814d9fdc0b3c4702a6840c387db96e
parent cfd03fe5df17cf538a63442cd87e14e60b0b00aa

Filter: Delete SEL not supported through filter

Issue: Doing SEL reserve and issuing IPMI Delete SEL,
       returns 0xcb instead of 0xc1

Fix: fixed by returning proper error code as invalid command (0xc1)

Tested:
verified with ipmitool raw commands

Command : ipmitool raw 0x0a 0x42 //reserve Sel
Response: 05 00

Command : ipmitool raw 0x0a 0x46 0x05 0x00 0xff 0xff // delete Sel
Response: Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0
          cmd=0x46 rsp=0xc1): Invalid command

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ie89c3dd9d48a0c586f2782f2e528e540ed156bc3

src/manufacturingcommands.cpp

diff --git a/src/manufacturingcommands.cpp b/src/manufacturingcommands.cpp
index 8b3d846..051f5be 100644
--- a/src/manufacturingcommands.cpp
+++ b/src/manufacturingcommands.cpp
@@ -673,7 +673,7 @@
                     return ipmi::ccInsufficientPrivilege;
                 }
             }
-            break;
+            return ipmi::ccSuccess;
         case makeCmdKey(ipmi::netFnOemOne,
                         ipmi::intel::general::cmdGetSmSignal):
         case makeCmdKey(ipmi::netFnOemOne,
@@ -691,6 +691,11 @@
             {
                 return ipmi::ccInvalidCommand;
             }
+            return ipmi::ccSuccess;
+        case makeCmdKey(ipmi::netFnStorage, ipmi::storage::cmdDeleteSelEntry):
+        {
+            return ipmi::ccInvalidCommand;
+        }
     }
     return ipmi::ccSuccess;
 }