commit 2daecd6f3f61da06c77764d1c86409922c5aa477
author Matt Simmering <matthew.simmering@intel.com> Thu May 19 12:50:53 2022 -0700
committer Matt Simmering <matthew.simmering@intel.com> Tue May 24 10:28:27 2022 -0700
tree 9b9db9ff19015860a05e35612aecbf6e6b993cbc
parent 429b085783f258da89d5c5b2979ba7030aef4d2b

biosConfigCommands: Add check for invalid paramSel

Add additional check in Get Payload IPMI
command for parameter selection.  Check
that it's a valid parameter.

Tested: When parameter selection is set above max
we're returning the expected error code 0xcc
instead of 0xff.

Change-Id: I77f94a164fb9f05a7d17ad558a9afb91b762b6c8
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

src/biosconfigcommands.cpp

diff --git a/src/biosconfigcommands.cpp b/src/biosconfigcommands.cpp
index 805306e..83b8959 100644
--- a/src/biosconfigcommands.cpp
+++ b/src/biosconfigcommands.cpp
@@ -105,7 +105,8 @@
 {
     GetPayloadInfo = 0, // 0
     GetPayloadData = 1, // 1
-    GetPayloadStatus = 2
+    GetPayloadStatus = 2,
+    MaxPayloadParameters
 };
 
 namespace payload1
@@ -927,6 +928,12 @@
     //      1-OOB BIOS config is supported
     message::Payload retValue;
 
+    if (static_cast<GetPayloadParameter>(paramSel) >=
+        ipmi::GetPayloadParameter::MaxPayloadParameters)
+    {
+        return ipmi::responseInvalidFieldRequest();
+    }
+
     if (!(gNVOOBdata.mBIOSCapabilities.OOBCapability & (biosCapOffsetBit)))
     {
         return ipmi::response(ipmiCCBIOSCapabilityInitNotDone);