commit 36ed8d24722e26271c395c8149d2c9fd68479087
author P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Wed Aug 04 01:14:14 2021 +0530
committer P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Sun Aug 22 19:12:11 2021 +0000
tree 240126e4fa7326b7beedac1072242df879b34e46
parent 2346b5d2af99f433573a5052cd48700121db6424

Fix Klocwork Issue: Uninitialized variable

The boolean return value(ret) from smbiosUnlock() function is been
declared but not initialized.
Assigning "false" as the default value.

The variable "value" in getMultiNodeRole() function is declared, but
is being initialized in if-else-if condition, and missses the final else
condition which could render the variable "value" to be uninitialized.
Adding an else condition to return nullopt to fix this issue.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I51088b91d1d48ad1d1cc4779b2ed58fd2b79ee9c

src/multinodecommands.cpp

diff --git a/src/multinodecommands.cpp b/src/multinodecommands.cpp
index d55b2f0..20a1841 100644
--- a/src/multinodecommands.cpp
+++ b/src/multinodecommands.cpp
@@ -67,6 +67,13 @@
             value = static_cast<uint8_t>(NodeRole::slave);
         else if (valueStr == "arbitrating")
             value = static_cast<uint8_t>(NodeRole::arbitrating);
+        else
+        {
+            phosphor::logging::log<phosphor::logging::level::ERR>(
+                "getMultiNodeRole: Invalid dbus value!",
+                phosphor::logging::entry("VALUE=%s", valueStr.c_str()));
+            return std::nullopt;
+        }
         return value;
     }
     catch (const std::exception& e)

src/smbiosmdrv2handler.cpp

diff --git a/src/smbiosmdrv2handler.cpp b/src/smbiosmdrv2handler.cpp
index ea4a794..55cd79a 100644
--- a/src/smbiosmdrv2handler.cpp
+++ b/src/smbiosmdrv2handler.cpp
@@ -872,7 +872,7 @@
 
 bool MDRV2::smbiosUnlock(uint8_t index)
 {
-    bool ret;
+    bool ret = false;
     switch (smbiosDir.dir[index].stage)
     {
         case MDR2SMBIOSStatusEnum::mdr2Updating: