Fix Klocwork Issue: Uninitialized variable
The boolean return value(ret) from smbiosUnlock() function is been
declared but not initialized.
Assigning "false" as the default value.
The variable "value" in getMultiNodeRole() function is declared, but
is being initialized in if-else-if condition, and missses the final else
condition which could render the variable "value" to be uninitialized.
Adding an else condition to return nullopt to fix this issue.
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I51088b91d1d48ad1d1cc4779b2ed58fd2b79ee9c
diff --git a/src/multinodecommands.cpp b/src/multinodecommands.cpp
index d55b2f0..20a1841 100644
--- a/src/multinodecommands.cpp
+++ b/src/multinodecommands.cpp
@@ -67,6 +67,13 @@
value = static_cast<uint8_t>(NodeRole::slave);
else if (valueStr == "arbitrating")
value = static_cast<uint8_t>(NodeRole::arbitrating);
+ else
+ {
+ phosphor::logging::log<phosphor::logging::level::ERR>(
+ "getMultiNodeRole: Invalid dbus value!",
+ phosphor::logging::entry("VALUE=%s", valueStr.c_str()));
+ return std::nullopt;
+ }
return value;
}
catch (const std::exception& e)