commit 3fbe8d2a932bb55c68d7bdb6f16e6d1753a67ee7
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Thu Oct 29 14:42:59 2020 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Wed Dec 02 19:15:47 2020 +0000
tree c3b872fae7fafe15397ae9768ea40a8ca0f5ae93
parent aedf5a9efe124853b3c722e155fea931befce89d

ipmiUserSetUserName argument change

ipmiUserSetUserName API signature is changed to use string variable.

Tested:
Verified using cmdtool utility command
Command: cmdtool.efi 20 c0 5a 64 65 62 75 67 75 73 65 72 0 0 0 0 0 0 0
 30 70 65 6e 42 6d 63 31 0 0 0 0 0 0 0 0 0 0 0 0
Response: User is created successfully
Command: ipmitool user list 1 //User list for channel 1
Response:
ID  Name             Callin  Link Auth  IPMI Msg   Channel Priv Limit
1   root             false   true       true       ADMINISTRATOR
2   debuguser        true    false      false      NO ACCESS
3   user3            true    false      false      NO ACCESS
4   user4            true    false      false      NO ACCESS

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I3462b7ea4928f3d6bb370c4c97fbe9cb543a3375

src/oemcommands.cpp

diff --git a/src/oemcommands.cpp b/src/oemcommands.cpp
index 107a1fe..bf23241 100644
--- a/src/oemcommands.cpp
+++ b/src/oemcommands.cpp
@@ -1096,7 +1096,10 @@
 
     // ipmiUserSetUserName correctly handles char*, possibly non-null
     // terminated strings using ipmiMaxUserName size
-    auto userNameRaw = reinterpret_cast<const char*>(userName.data());
+    size_t nameLen = strnlen(reinterpret_cast<const char*>(userName.data()),
+                             sizeof(userName));
+    const std::string userNameRaw(
+        reinterpret_cast<const char*>(userName.data()), nameLen);
 
     if (ipmi::ccSuccess == ipmiUserSetUserName(ipmiDefaultUserId, userNameRaw))
     {
@@ -1118,7 +1121,7 @@
         }
         // we need to delete  the default user id which added in this command as
         // password / priv setting is failed.
-        ipmiUserSetUserName(ipmiDefaultUserId, "");
+        ipmiUserSetUserName(ipmiDefaultUserId, static_cast<std::string>(""));
         phosphor::logging::log<phosphor::logging::level::ERR>(
             "ipmiOEMSetUser2Activation: password / priv setting is failed.");
     }