commit 3ff6371ba7e5c7f02d6851d6a87e7dbbdfa093e6
author sunitakx <sunitax.kumari@linux.intel.com> Wed Jun 09 15:47:32 2021 +0000
committer AppaRao Puli <apparao.puli@linux.intel.com> Mon Jun 21 05:03:43 2021 +0000
tree 1a0d5e8a4f8aeaf611986abfcb987cbc8451a3e4
parent 24df90f705920e1a745d5a2270dccf90be90d954

[Chassis]: Validate reserved field content is zero

In Set Front Panel Button Enables Command, byte-1’s [7:4] is reserved.
Return InvalidFieldRequest when reserved content is non-zero.
Tested:
~# ipmitool raw 0x00 0x0a 0x10
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0xa rsp=0xcc)
:Invalid data field in request

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I20284f741ce7e2c235d48ba905d922db5c9d2885

src/chassiscommands.cpp

diff --git a/src/chassiscommands.cpp b/src/chassiscommands.cpp
index 360e787..2206d77 100644
--- a/src/chassiscommands.cpp
+++ b/src/chassiscommands.cpp
@@ -613,6 +613,10 @@
                                                bool disableSleepButton,
                                                uint4_t reserved)
 {
+    if (reserved)
+    {
+        return ipmi::responseInvalidFieldRequest();
+    }
     bool error = false;
 
     error |= setButtonEnabled(powerButtonPath, disablePowerButton);
@@ -623,6 +627,7 @@
     {
         return ipmi::responseUnspecifiedError();
     }
+
     return ipmi::responseSuccess();
 }