commit 429b085783f258da89d5c5b2979ba7030aef4d2b
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Tue May 10 18:46:50 2022 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Wed May 11 07:09:01 2022 +0000
tree 25995b7f943ce848922086bfeaac725549f57d34
parent 493d77616dbd9cd5d0431b2db9775c0f7b052c3b

Fix for ClearMessageFlags IPMI command

Issue: "In ClearMessageFlags IPMI command implementation, Watchdog
pre-timeout interrupt flag is cleared unconditionally. Due to that
Get Message Flags IPMI command response is not expected.

Fix: In ClearMessageFlags, Set dbus property
"PreTimeoutInterruptOccurFlag" of interface
"xyz.openbmc_project.State.Watchdog" to actual user input.

Tested:
1. Verified using cmdtool utility and clear linux OS.
Command: ipmitool raw 6 0x24 0x5 0x33 0x5 0x3e 0x64 0x00
                      //Set watchdog timer
Response:            //Success
Command: ipmitool raw 6 0x22 //Reset Watchdog Timer
Response:            //Success
Command: ipmitool raw 6 0x25  //Get Watchdog Timer
Response: 05 33 00 00 64 00 64 00

Verified from system interface using cmdtool utility and Clear linux.
Command: > cmdtool.efi 20 18 31 //Get Message Flags
Response: 00 0A

Signed-off-by: JitendraKumar Tripathy
<jitendra.kumarx.tripathy@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ib5e25268204295e5250fb8500d95a1f0169f2043

src/bridgingcommands.cpp

diff --git a/src/bridgingcommands.cpp b/src/bridgingcommands.cpp
index 916ba15..7ae513c 100644
--- a/src/bridgingcommands.cpp
+++ b/src/bridgingcommands.cpp
@@ -662,7 +662,7 @@
     {
         std::shared_ptr<sdbusplus::asio::connection> dbus = getSdBus();
         ipmi::setDbusProperty(*dbus, wdtService, wdtObjPath, wdtInterface,
-                              wdtInterruptFlagProp, false);
+                              wdtInterruptFlagProp, watchdogTimeout);
     }
     catch (const sdbusplus::exception::exception& e)
     {