tree 552d3e34f4f154c7268a80753703a97590a8d7b0
parent 7599bcf9bbd9ba2ca4a7d4e6528ecbe7309769ae
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> 1653922261 +0000
committer AppaRao Puli <apparao.puli@intel.com> 1655695398 +0000

Conditionally clear watchdog pre-timeout interrupt

"Clear Message Flags" IPMI command is used to clear the Event Message
buffer, Receive Message queue and Watchdog pre-timeout interrupt flag
if that specific BIT is set.

Existing code is setting the "Watchdog Pre-timeout interrupt" flag to
True when user (host/end user) tries to clear other bits like Message
Buffer or Receive Message Queue which is not correct. So correct the
condition to clear "watchdog Pre-timeout interrupt" flag only if BIT 3
is set.

Tested:
Verified using cmdtool utility and clear linux OS.

On Cmdtool-
Case 1: When "PreTimeoutInterruptOccurFlag" flag is enable and clear
other flags
Command: > cmdtool.efi 20 18 31 //Get Message Flags
Response: 00 08
Command: > cmdtool.efi 20 18 30 2 //Clear Message Flags
Response: 00
Command: > cmdtool.efi 20 18 31 //Get Message Flags
Response: 00 08    //watchdog "PreTimeoutInterruptOccurFlag" is not
                    //cleared

Case 2: When "PreTimeoutInterruptOccurFlag" flag is enable and clear
PreTimeoutInterruptOccurFlag
Command: > cmdtool.efi 20 18 30 8 //Clear Message Flags
Response: 00
Command: > cmdtool.efi 20 18 31 //Get Message Flags
Response: 00 02   //watchdog "PreTimeoutInterruptOccurFlag" is not
                  //cleared

On Linux OS-
Case 1: When "PreTimeoutInterruptOccurFlag" flag is enable and clear
other flags
Command: ipmitool raw 0x06 0x31 //get message flags
Response: 08
Command: ipmitool raw 0x06 0x30 0x02 // clear message flags
Response:              //Success
Command: ipmitool raw 0x06 0x31 //get message flags
Response: 08

Case 2: When "PreTimeoutInterruptOccurFlag" flag is enable and clear
PreTimeoutInterruptOccurFlag
Command: ipmitool raw 0x06 0x30 0x08 // clear message flags
Response:              //Success
Command: ipmitool raw 0x06 0x31 //get message flags
Response: 02

Signed-off-by: JitendraKumar Tripathy
<jitendra.kumarx.tripathy@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I85a742c6d5799fe31b4c0a64b3d4f62256772be6