commit 6224dec4a92aa4924cb6f75c2646096fb9466f28
author Snehalatha Venkatesh <snehalathax.v@intel.com> Tue Jan 24 11:28:53 2023 +0000
committer Snehalatha Venkatesh <snehalathax.v@intel.com> Fri Jan 27 06:36:08 2023 +0000
tree c0dbd5fce975562a5f8c831c642f3b5c90849862
parent 7f819e8bff935f539086ceda2dcb6faa2cb57195

Fix for GetFanControlConfiguration IPMI command

GetFanControlConfiguration IPMI command not working as expepcted.
So updated busctl interface to fetch correct service from object Mapper.

Tested:
Before Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x8a
rsp=0xcc): Invalid data field in request
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/CPU_1
1 "xyz.openbmc_project.Inventory.Item"
Response: Call failed: The resource is not found.

After Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response: 80 00 04 00 00 00 00
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0
1 "xyz.openbmc_project.Inventory.Item"
Response: a{sas} 1 "xyz.openbmc_project.Smbios.MDR_V2" 10
"org.freedesktop.DBus.Introspectable" "org.freedesktop.DBus.Peer"
"org.freedesktop.DBus.Properties" "xyz.openbmc_project.Association.Definitions"
"xyz.openbmc_project.Inventory.Connector.Slot"
"xyz.openbmc_project.Inventory.Decorator.Asset"
"xyz.openbmc_project.Inventory.Decorator.LocationCode"
"xyz.openbmc_project.Inventory.Decorator.Revision"
"xyz.openbmc_project.Inventory.Item" "xyz.openbmc_project.Inventory.Item.Cpu"

Change-Id: Ic212637113c3cb52867ba7addcb599547c1ce7a2
Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>

src/oemcommands.cpp

diff --git a/src/oemcommands.cpp b/src/oemcommands.cpp
index 1f8b99b..cb506c9 100644
--- a/src/oemcommands.cpp
+++ b/src/oemcommands.cpp
@@ -1707,7 +1707,7 @@
         {
             return ipmi::responseInvalidFieldRequest();
         }
-        if (!cpuPresent("CPU_" + std::to_string(*dimmGroupId + 1)))
+        if (!cpuPresent("cpu" + std::to_string(*dimmGroupId)))
         {
             return ipmi::responseInvalidFieldRequest();
         }
@@ -1781,7 +1781,7 @@
         return ipmi::responseInvalidFieldRequest();
     }
 
-    bool cpuStatus = cpuPresent("CPU_" + std::to_string(dimmGroupId + 1));
+    bool cpuStatus = cpuPresent("cpu" + std::to_string(dimmGroupId));
 
     if (!cpuStatus)
     {