Add missed path in sm signal for identify button
Identify button case was missed out earlier. Added
the same to return proper path for identify button.
Also updated to override with Sample action, when
revert or ignore is requested, as ID button won't
support ButtonMasked property
Tested:
1. After entering to manufacturing mode, queried
the sample of identify button and value as expected
was returned.
Change-Id: Icdd972c05a3abef653474bcc0aa7c4d376b9cbb6
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
diff --git a/src/manufacturingcommands.cpp b/src/manufacturingcommands.cpp
index 0be16ee..a85b872 100644
--- a/src/manufacturingcommands.cpp
+++ b/src/manufacturingcommands.cpp
@@ -54,6 +54,9 @@
case SmSignalGet::smNMIButton:
path = "/xyz/openbmc_project/chassis/buttons/nmi";
break;
+ case SmSignalGet::smIdentifyButton:
+ path = "/xyz/openbmc_project/chassis/buttons/id";
+ break;
default:
return -1;
break;
@@ -306,10 +309,20 @@
return ipmi::responseSuccess(sensorVal, fanTach);
}
break;
+ case SmSignalGet::smIdentifyButton:
+ {
+ if (action == SmActionGet::revert || action == SmActionGet::ignore)
+ {
+ // ButtonMasked property is not supported for ID button as it is
+ // unnecessary. Hence if requested for revert / ignore, override
+ // it to sample action to make tools happy.
+ action = SmActionGet::sample;
+ }
+ // fall-through
+ }
case SmSignalGet::smResetButton:
case SmSignalGet::smPowerButton:
case SmSignalGet::smNMIButton:
- case SmSignalGet::smIdentifyButton:
{
std::string path;
if (getGpioPathForSmSignal(signalType, path) < 0)