commit 919075d2a65526bf1c191bce77d2058b9732a67d
author PavanKumarIntel <pavanx.kumar.martha@intel.com> Mon Oct 30 16:41:19 2023 +0000
committer PavanKumarIntel <pavanx.kumar.martha@intel.com> Thu Nov 16 13:20:30 2023 +0000
tree 5286ded2a83ed79c19825810eb8fdd96a8a7de91
parent 87381417f045de7465bf1a3a80ad41e8f35ef54e

Fix the bugs found in static analysis

This commit fixes the static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Change-Id: Icea12472652440b8c66e79491ffe43f2b18cf381
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

src/bridgingcommands.cpp

diff --git a/src/bridgingcommands.cpp b/src/bridgingcommands.cpp
index f1fa2e1..eb6d903 100644
--- a/src/bridgingcommands.cpp
+++ b/src/bridgingcommands.cpp
@@ -99,14 +99,14 @@
 }
 
 static inline bool ipmbDataChecksumValidate(const ipmbHeader* ipmbHeader,
-                                            uint8_t length)
+                                            size_t length)
 {
     return ipmbChecksumValidate((reinterpret_cast<const uint8_t*>(ipmbHeader) +
                                  ipmbConnectionHeaderLength),
                                 (length - ipmbConnectionHeaderLength));
 }
 
-static bool isFrameValid(const ipmbHeader* frame, uint8_t length)
+static bool isFrameValid(const ipmbHeader* frame, size_t length)
 {
     if ((length < ipmbMinFrameLength) || (length > ipmbMaxFrameLength))
     {