Specify "8-bit ASCII + Latin 1" SDR encoding
Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].
This results in issues with VMWare ESXi which uses IPMI to fetch sensor
data from the BMC, all the names are shown as "Unspecified 1" (if
default EntityId is used), so status page, SEL entries and the logs
become very confusing.
Fix this by telling it to process all bytes as is by using "8-bit ASCII
+ Latin 1" type.
Tested with VMWare ESXi 7.0 Update 2 and regular ipmitool (using GNU
FreeIPMI), both shows names correctly.
[0] https://github.com/kofemann/opensolaris/blob/master/usr/src/lib/libipmi/common/ipmi_util.c#L258
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: I53d74944717b1642eab6bee3c2c8566a1b8808b1
diff --git a/src/sensorcommands.cpp b/src/sensorcommands.cpp
index 2964513..b8b40e0 100644
--- a/src/sensorcommands.cpp
+++ b/src/sensorcommands.cpp
@@ -1488,7 +1488,8 @@
name.resize(FULL_RECORD_ID_STR_MAX_LENGTH);
}
- record.body.id_string_info = name.size();
+ get_sdr::body::set_id_strlen(name.size(), &record.body);
+ get_sdr::body::set_id_type(3, &record.body); // "8-bit ASCII + Latin 1"
std::strncpy(record.body.id_string, name.c_str(),
sizeof(record.body.id_string));