commit 98cb6186e77fb820dd26666118964897d36730be
author Arun P. Mohanan <arun.p.m@linux.intel.com> Tue Aug 31 19:49:19 2021 +0530
committer Arun P M <arun.p.m@linux.intel.com> Mon Sep 06 08:38:57 2021 +0000
tree 0b300169eabb99a0f17a62d979f6bb564ae37989
parent 153d4c14af30e579ddc7fa3489ffe382b1a3f9ce

fix: Correct bit mask for GetBMCServiceStatus cmd

Bit 14 and 15 of GetBMCServiceStatus command response represents
status of Video and USB redirection. These 2 bits should match since
a single service maintains both. The logic for the same is already
implemented. But incorrect mask resulted in error values when previously
un-used bits(bit 13) got defined for new services.

This change corrects the bit mask to extract only bit 15

Tested:
Verified commands is giving expected response
Command:  ipmitool raw 0x30 0xb2
Response: 68 e0
Command:  ipmitool raw 0x30 0xB1 0x00 0x68 0xe0
Response: Success
Command: ipmitool raw 0x30 0xb2
Response: 00 00

Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Change-Id: Iba8e44fe6ee21e599c6f1575c7ba90a48cdee746

src/bmccontrolservices.cpp

diff --git a/src/bmccontrolservices.cpp b/src/bmccontrolservices.cpp
index 3ab1f81..0d2e7a0 100644
--- a/src/bmccontrolservices.cpp
+++ b/src/bmccontrolservices.cpp
@@ -41,7 +41,7 @@
     {kvmServiceBitPos, "/xyz/openbmc_project/control/service/start_2dipkvm"},
 };
 
-static constexpr uint16_t maskBit15 = 0xF000;
+static constexpr uint16_t maskBit15 = 0x8000;
 
 static constexpr const char* objectManagerIntf =
     "org.freedesktop.DBus.ObjectManager";