commit 99d7d35f717501437bfcaee8860f187b2aacd058
author Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> Mon Nov 11 12:11:35 2019 +0530
committer Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> Mon Nov 18 16:38:16 2019 +0000
tree f3c3391fbc32dcf567e3a820a6d90b8aa3f5d426
parent 8d4f8d738e1b87c5ce9a06f8e0f2d3a5f577513d

Allow mfg commands in validation unsecure mode

Execute all the manufacturing commands in validation
unsecure mode, which will be available if validation-unsecure
feature is enabled.

Tested:
Depends on patch, which enables this flag
based on validation-unsecure
1. Verified that features is enabled with validation-unsecure
2. Verified mfg commands are executed in both mfg & validation
unsecure mode.

Change-Id: Id75086d9998b334d5d138ee8ebeade0fc305bc08
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 218c5c6..42af35a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -105,7 +105,13 @@
 
 install (TARGETS zinteloemcmds DESTINATION lib/ipmid-providers)
 option (INTEL_PFR_ENABLED "Intel PFR Enabled" OFF)
+option (BMC_VALIDATION_UNSECURE_FEATURE
+        "Enables unsecure features required by validation. Note: must
+        be turned off for production images."
+        OFF)
 target_compile_definitions (
     zinteloemcmds PRIVATE
     $<$<BOOL:${INTEL_PFR_ENABLED}>: -DINTEL_PFR_ENABLED>
+    $<$<BOOL:${BMC_VALIDATION_UNSECURE_FEATURE}>:
+    -DBMC_VALIDATION_UNSECURE_FEATURE>
 )

include/manufacturingcommands.hpp

diff --git a/include/manufacturingcommands.hpp b/include/manufacturingcommands.hpp
index f68142e..9246de9 100644
--- a/include/manufacturingcommands.hpp
+++ b/include/manufacturingcommands.hpp
@@ -247,6 +247,14 @@
         {
             return true;
         }
+#ifdef BMC_VALIDATION_UNSECURE_FEATURE
+        if (std::get<std::string>(mode) ==
+            "xyz.openbmc_project.Control.Security.SpecialMode.Modes."
+            "ValidationUnsecure")
+        {
+            return true;
+        }
+#endif
         return false;
     }