commit 9f8d027a411c77b13a92d3eae2fcc9747f484a3c
author P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Wed Jul 14 19:13:49 2021 +0530
committer Vernon Mauery <vernon.mauery@linux.intel.com> Wed Jul 14 20:59:46 2021 +0000
tree afc90aa67f3072c458ddfe301089171d6ea399d3
parent c08e975234ebd5caec937f3a94d4464644772322

Klockwork Issue Fix : Index range check

Though the caller of smbiosIsUpdating() is handling index range check
(#757), it is preferable that the function also has the right check in
place. With the present implementation, index can go up to maxDirEntries
which is not the correct functionality. This commit fixes the range
check.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I4f3cb15c3a26e9462ee6e0f425c8e9156bce4731

src/smbiosmdrv2handler.cpp

diff --git a/src/smbiosmdrv2handler.cpp b/src/smbiosmdrv2handler.cpp
index 058c3ee..ea4a794 100644
--- a/src/smbiosmdrv2handler.cpp
+++ b/src/smbiosmdrv2handler.cpp
@@ -194,7 +194,7 @@
 
 bool MDRV2::smbiosIsUpdating(uint8_t index)
 {
-    if (index > maxDirEntries)
+    if (index >= maxDirEntries)
     {
         return false;
     }