Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / intel-ipmi-oem / c08e975234ebd5caec937f3a94d4464644772322
commitc08e975234ebd5caec937f3a94d4464644772322[log] [tgz]
authorP Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>Wed Jul 14 19:38:32 2021 +0530
committerP Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>Wed Jul 14 19:38:32 2021 +0530
tree54aa011ba34cf678f7e8be7847c6cc7f3b8ea11c
parent0a652fa9ca42b24190f8073b9de71bfbdaf54cf2 [diff]
Klocwork Issue Fix - File Resource Lost

In the event when file_size() fails and file open was successful,
with the current implementation, the function would return without
closing the file.
This commit fixes this condition by having separate checks for
file_size error code and file open failure.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I44e46a4093f5fab087b40bb95440fbb3d215bad8
1 file changed
tree: 54aa011ba34cf678f7e8be7847c6cc7f3b8ea11c
  1. cmake/
  2. docs/
  3. include/
  4. non-yocto/
  5. src/
  6. tests/
  7. .clang-format
  8. .gitignore
  9. cmake-format.json
  10. CMakeLists.txt
  11. CMakeLists.txt.in
  12. generate-whitelist.py
  13. ipmi-whitelist.conf
  14. LICENSE
  15. MAINTAINERS
  16. README.md
README.md

Intel IPMI OEM support library

This component is intended to provide Intel-specific IPMI[3] command handlers for OpenBMC. These handlers are intended to integrate BMC with servers based on Intel architecture.

Overview

intel-ipmi-oem serves as an extension[1] to OpenBMC IPMI daemon[2]. It is compiled as a shared library and intended to both:

  • override existing implementation of standard IPMI commands to comply with Intel-specific solutions,
  • provide implementation for non-standard OEM extensions.

Capabilities

Related features provided by the library are grouped in separate source files. Main extensions to vanilla OpenBMC IPMI stack are the following:

  • Acquiring SMBIOS data over IPMI
  • Commands for better integration with Intel hardware
  • Firmware update extensions
  • Extended parsing of IPMI Platform Events[4]

References

  1. OpenBMC IPMI Architecture
  2. Phosphor IPMI Host
  3. IPMI Specification v2.0
  4. Intel Platform Events parsing