commit d33b11ca028bd4ff74e6eaca62de2e32867b8877
author AppaRao Puli <apparao.puli@linux.intel.com> Wed Oct 16 17:59:22 2019 +0530
committer AppaRao Puli <apparao.puli@linux.intel.com> Thu Oct 17 02:10:33 2019 +0000
tree 736aa52d2a387b3d36d17f5a129673777a88e135
parent df5e3271223d576b196106cc43f5e0a12476f61f

Cleaned not implemented commands from registration

Removed not implemented firmware (netfn: 0x08) commands
from registration. Let the execution queue to return
appropriate response, if a handler is not registered.

We can register them, when they get implemented.

Tested:
Tested with unregistered command and verified CC.
Request: ipmitool raw 8 0xFF
Response: 0xC1 - Invalid command

Change-Id: I6f6846c8d3e84ccc681b9fd00cef1af8b5ce1722
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

src/firmware-update.cpp

diff --git a/src/firmware-update.cpp b/src/firmware-update.cpp
index 4fdee8b..e836458 100644
--- a/src/firmware-update.cpp
+++ b/src/firmware-update.cpp
@@ -1631,29 +1631,6 @@
     return IPMI_CC_OK;
 }
 
-static constexpr char NOT_IMPLEMENTED[] = "NOT IMPLEMENTED";
-
-static ipmi_ret_t ipmi_firmware_wildcard_handler(
-    ipmi_netfn_t netfn, ipmi_cmd_t cmd, ipmi_request_t request,
-    ipmi_response_t response, ipmi_data_len_t data_len, ipmi_context_t context)
-{
-    if (DEBUG)
-        std::cerr << "Handling stubbed Netfn:[0x" << std::hex << +netfn
-                  << "], Cmd:[0x" << std::hex << +cmd << "]\n";
-
-    // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
-
-    *data_len = sizeof(NOT_IMPLEMENTED);
-
-    // Now pack actual response
-    char *msg_reply = static_cast<char *>(response);
-    std::copy(std::begin(NOT_IMPLEMENTED), std::end(NOT_IMPLEMENTED),
-              msg_reply);
-
-    return rc;
-}
-
 struct intc_app_get_buffer_size_resp
 {
     uint8_t kcs_size;
@@ -1771,24 +1748,6 @@
     ipmi_register_callback(NETFUN_FIRMWARE, IPMI_CMD_FW_IMAGE_WRITE, NULL,
                            ipmi_firmware_write_data, PRIVILEGE_ADMIN);
 
-    // get update timestamps
-    ipmi_register_callback(NETFUN_FIRMWARE, IPMI_CMD_FW_GET_TIMESTAMP, NULL,
-                           ipmi_firmware_wildcard_handler, PRIVILEGE_ADMIN);
-
-    // get error message (when in error state)
-    ipmi_register_callback(NETFUN_FIRMWARE, IPMI_CMD_FW_GET_UPDATE_ERR_MSG,
-                           NULL, ipmi_firmware_wildcard_handler,
-                           PRIVILEGE_ADMIN);
-
-    // get remote firmware information (PSU, HSBP, etc.)
-    ipmi_register_callback(NETFUN_FIRMWARE, IPMI_CMD_FW_GET_REMOTE_FW_INFO,
-                           NULL, ipmi_firmware_wildcard_handler,
-                           PRIVILEGE_ADMIN);
-
-    // <Wildcard Command>
-    ipmi_register_callback(NETFUN_FIRMWARE, IPMI_CMD_WILDCARD, NULL,
-                           ipmi_firmware_wildcard_handler, PRIVILEGE_ADMIN);
-
     // get buffer size is used by fw update (exclusively?)
     ipmi_register_callback(NETFUN_INTC_APP, IPMI_CMD_INTC_GET_BUFFER_SIZE, NULL,
                            ipmi_intel_app_get_buffer_size, PRIVILEGE_USER);