commit e8cecdffbbe5997090230b193b09bfe0ea9ae459
author Cheng C Yang <cheng.c.yang@linux.intel.com> Mon Aug 26 23:48:08 2019 +0800
committer Cheng C Yang <cheng.c.yang@linux.intel.com> Wed Aug 28 14:13:54 2019 +0000
tree 693e46cf223a825921ff9b4222b6d343e273c963
parent 85feb13037fba1df6a26417b3e358cb2a4f53050

Fix the incorrect completion code

When running set cold redundancy configuration command, it always return
incorrect completion code, the string value of ColdRedundancyStatus always be
sent to dbus as a bool type.

Tested:
ipmitool raw 0x30 0x2d 0x01 0x00 return 00.
ipmitool raw 0x30 0x2d 0x02 0x00 return 00.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: If5c8d625af78f9331e713b275bf53fccb33fcc46

src/oemcommands.cpp

diff --git a/src/oemcommands.cpp b/src/oemcommands.cpp
index aa8330e..214f536 100644
--- a/src/oemcommands.cpp
+++ b/src/oemcommands.cpp
@@ -2063,8 +2063,8 @@
 
     // TODO Halfwidth needs to set SetInProgress
     if (setCRConfig(ctx, "ColdRedundancyStatus",
-                    "xyz.openbmc_project.Control.PowerSupplyRedundancy.Status."
-                    "completed"))
+                    std::string("xyz.openbmc_project.Control."
+                                "PowerSupplyRedundancy.Status.completed")))
     {
         return ipmi::responseResponseError();
     }