commit f365614c146eceebbfcfef0f7bedc8215d143715
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Sun Jan 24 01:04:19 2021 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Tue Mar 09 06:30:20 2021 +0000
tree 55e5c1f708b59208695bb64c37b5b6cd0958e923
parent 17eadbfba70c56b36fd1b7c2b8fc2b0afe4f6771

Fix for ID LED smsignal configuration

Issue: ID LED status reverting to default state after exiting
       manufacturing mode

Fix: Provided fix for ID LED status should not revert to default state
     after exiting manufacturing mode

Tested:
1. Keep the BMC in Manufacturing mode
2. Update Physical LED state to ON.
Command:  ipmitool raw 0x30 0x15 0x0d 0x00 0x01
Response: Success
3. Check the status of ID LED status
Command: busctl get-property xyz.openbmc_project.LED.Controller.identify
         /xyz/openbmc_project/led/physical/identify
         xyz.openbmc_project.Led.Physical State
Response: s "xyz.openbmc_project.Led.Physical.Action.On"
4. Wait for Manufacturing mode to exit and verify ID LED status.
   LED status is showing ON even after existing from mfg mode.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ia7fe1946cd5c93a0f145b230026abde5ae724d48

src/manufacturingcommands.cpp

diff --git a/src/manufacturingcommands.cpp b/src/manufacturingcommands.cpp
index 6423289..c92dd00 100644
--- a/src/manufacturingcommands.cpp
+++ b/src/manufacturingcommands.cpp
@@ -200,6 +200,11 @@
     for (const auto& ledProperty : ledPropertyList)
     {
         const std::string& ledName = ledProperty.getName();
+        if (ledName == "identify" && mtm.getMfgMode() == SpecialMode::mfg)
+        {
+            // Don't revert the behaviour for manufacturing mode
+            continue;
+        }
         ledRevert(ledProperty.getSignal());
     }
 }