commit ff7e15b24ae4b9434d2afdeb570ebde90afde1f9
author Patrick Venture <venture@google.com> Wed Sep 25 16:48:26 2019 -0700
committer Patrick Venture <venture@google.com> Thu Sep 26 16:37:35 2019 +0000
tree c42fc92c6c76566a19e722b15535c7b55486488e
parent b10ec8b37491695c2b0a72afbf46a0cf6ebdb221

storagecommands: pass by reference

[src/storagecommands.cpp:598]:
[src/storagecommands.cpp:628]:
(performance) Function parameter 'selLogFiles' should be passed by const reference.
[src/storagecommands.cpp:642]:
(performance) Function parameter 'hexStr' should be passed by const reference.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0528a122f34e9b53627f041c1bdd7be4f34858ed

src/storagecommands.cpp

diff --git a/src/storagecommands.cpp b/src/storagecommands.cpp
index b35ae9b..c89ad82 100644
--- a/src/storagecommands.cpp
+++ b/src/storagecommands.cpp
@@ -589,7 +589,7 @@
 }
 
 static bool findSELEntry(const int recordID,
-                         const std::vector<std::filesystem::path> selLogFiles,
+                         const std::vector<std::filesystem::path>& selLogFiles,
                          std::string& entry)
 {
     // Record ID is the first entry field following the timestamp. It is
@@ -619,7 +619,7 @@
 
 static uint16_t
     getNextRecordID(const uint16_t recordID,
-                    const std::vector<std::filesystem::path> selLogFiles)
+                    const std::vector<std::filesystem::path>& selLogFiles)
 {
     uint16_t nextRecordID = recordID + 1;
     std::string entry;
@@ -633,7 +633,7 @@
     }
 }
 
-static int fromHexStr(const std::string hexStr, std::vector<uint8_t>& data)
+static int fromHexStr(const std::string& hexStr, std::vector<uint8_t>& data)
 {
     for (unsigned int i = 0; i < hexStr.size(); i += 2)
     {