commit ec73c95892cbbabe9da556e1f68db70a7ff3d46a
author Brad Bishop <bradleyb@fuzziesquirrel.com> Wed Nov 21 16:04:13 2018 -0500
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Wed Nov 21 16:04:13 2018 -0500
tree 392d387bf13595ad150eaf64609f7a9ffddd08a9
parent 6cc890440830c135a0519bff739c68357f401852

frup: gcc8: swap abusive use strncpy w/ memcpy

Fix the following warning under gcc8:

| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ../git/frup.cpp:664:24: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
|                  strncpy(bin_in_ascii, "0x", 2);
|                  ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ia35d0ae733f0879f6c9d23126bab5fc899e89def
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

frup.cpp

diff --git a/frup.cpp b/frup.cpp
index 299c7cc..9ddb0f6 100644
--- a/frup.cpp
+++ b/frup.cpp
@@ -661,7 +661,7 @@
             /* We need the data represented as 0x...... */
             if (vpd_val_len > 0)
             {
-                strncpy(bin_in_ascii, "0x", 2);
+                memcpy(bin_in_ascii, "0x", 2);
             }
 #if IPMI_FRU_PARSER_DEBUG
             printf("_append_to_dict: VPD Key = [%s] : Type Code = [BINARY] :"