Fix randomizer
Relying on the system randomizer for unit tests leads to cases where we
don't get deterministic results, which causes inconsistent results.
These random results don't need to be secure, so reimplement as a simple
linear feedback shift register[1]. This makes our unit tests now
produce the same output every time we call generate.
Note, this change showed a weakness in our testing, where timestamps
relied on different rules for ir->cper versus cper->ir. hour 24 should
be allowed.
[1] https://en.wikipedia.org/wiki/Linear-feedback_shift_register
Change-Id: I0756b086c8ea5fb934e450f5d33e3ae0036868b3
Signed-off-by: Ed Tanous <ed@tanous.net>
diff --git a/generator/sections/gen-section-firmware.c b/generator/sections/gen-section-firmware.c
index 6ec4b88..bf8a7ee 100644
--- a/generator/sections/gen-section-firmware.c
+++ b/generator/sections/gen-section-firmware.c
@@ -25,10 +25,10 @@
}
//Set expected values.
- *(bytes + 1) = 2; //Revision, referenced version of spec is 2.
+ *(bytes + 1) = 2; //Revision, referenced version of spec is 2.
UINT64 *record_id = (UINT64 *)(bytes + 8);
- *record_id = 0; //Record ID, should be forced to NULL.
- *bytes = rand() % 3; //Record type.
+ *record_id = 0; //Record ID, should be forced to NULL.
+ *bytes = cper_rand() % 3; //Record type.
//Set return values, exit.
*location = bytes;