commit f0f95574276269bfe4b60cab00ed81a61fa4299b
author Lawrence Tang <lawrence.tang@arm.com> Thu Jul 07 16:56:22 2022 +0100
committer Lawrence Tang <lawrence.tang@arm.com> Thu Jul 07 16:56:22 2022 +0100
tree 1df2203349a68ff4d94269645c546e451629f7b8
parent 151c6cabc516592df6102ad2b0a62f374ae36858

Add README, reverse function signature.

cper-parse.c

diff --git a/cper-parse.c b/cper-parse.c
index fa2d796..4af39d8 100644
--- a/cper-parse.c
+++ b/cper-parse.c
@@ -34,15 +34,8 @@
 
 //Reads a CPER log file at the given file location, and returns an intermediate
 //JSON representation of this CPER record.
-json_object* cper_to_ir(const char* filename) 
+json_object* cper_to_ir(FILE* cper_file) 
 {
-    //Get a handle for the log file.
-    FILE* cper_file = fopen(filename, "r");
-    if (cper_file == NULL) {
-        printf("Could not open CPER record, file handle returned null.");
-        return NULL;
-    }
-
     //Ensure this is really a CPER log.
     EFI_COMMON_ERROR_RECORD_HEADER header;
     fseek(cper_file, 0, SEEK_SET);
@@ -58,16 +51,6 @@
         return NULL;
     }
 
-    // //Print struct contents (debug).
-    // fpos_t file_pos;
-    // fgetpos(cper_file, &file_pos);
-    // printf("Stream is at position %d.\n", file_pos);
-    // printf("SignatureStart: %s\n", (char*)&header.SignatureStart);
-    // printf("Revision: %u\n", header.Revision);
-    // printf("SectionCount: %u\n", header.SectionCount);
-    // printf("Severity: %d\n", header.ErrorSeverity);
-    // printf("RecordLength: %d\n", header.RecordLength);
-
     //Create the header JSON object from the read bytes.
     json_object* header_ir = cper_header_to_ir(&header);
 
@@ -95,7 +78,6 @@
     json_object_object_add(parent, "sectionDescriptors", section_descriptors_ir);
     json_object_object_add(parent, "sections", sections_ir);
 
-    //...
     return parent;
 }