astlpc: Provide KCS device path as a binding argument
Currently astlpc binding expects a '/dev/mctp0' device in the system
for the KCS communication. This device is a symbolic link to the
real '/dev/raw-kcsX' device, created by the udev rules populated by the
build system.
This approach is not ideal since the build system populates udev rules
for the KCS3 and KCS4 channels simultaneously and for these channels
only. This means that there are some design limitations for the MCTP
communication. It is only possible on KCS3 or KCS4 channel, and if one
of these channels is used, the other one must be disabled.
To make design more flexible get rid of all the udev rules and provide
'/dev/raw-kcsX' device path as an argument to the binding
initialization code.
Change-Id: I505e44280636c83b59669b314f60279b371d0403
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
diff --git a/configure.ac b/configure.ac
index 28d517e..519083f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,12 +21,6 @@
# pkg-config
PKG_PROG_PKG_CONFIG
PKG_INSTALLDIR
-PKG_CHECK_MODULES(udev,
- udev,
- [PKG_CHECK_VAR(udevdir, udev, udevdir)],
- [])
-
-AC_SUBST([udevrulesdir], [$udevdir/rules.d])
AC_ARG_ENABLE([capture],
[AC_HELP_STRING([--enable-capture],
@@ -41,11 +35,6 @@
AC_SUBST([pcap_LIBS])
AM_CONDITIONAL([HAVE_PCAP], [test "x$enable_capture" = "xyes"])
-AC_ARG_ENABLE([astlpc-raw-kcs],
- [AS_HELP_STRING([--enable-astlpc-raw-kcs],
- [Use udev rules to symlink raw-kcs device nodes for the astlpc binding])])
-AM_CONDITIONAL([LIBMCTP_UDEV_RAW_KCS], [test -n "$udevdir" -a "x$enable_astlpc_raw_kcs" = "xyes"])
-
AC_ARG_WITH([systemdsystemunitdir],
[AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],
[],
@@ -174,6 +163,5 @@
[AM_CONDITIONAL(AUTOCONF_CODE_COVERAGE_2019_01_06, [false])])
AX_ADD_AM_MACRO_STATIC([])
-AC_CONFIG_FILES([Makefile libmctp.pc udev/rules.d/mctp0-raw-kcs3.rules
- udev/rules.d/mctp0-raw-kcs4.rules])
+AC_CONFIG_FILES([Makefile libmctp.pc])
AC_OUTPUT