core: Remove Rube Goldberg sequence point in packet body assignment
The code isn't wrong* - if it were we certainly would have noticed - but
why it's *right* isn't something we want to be reasoning about.
Convert the sequence point to a plain statement to make the ordering and
value state requirements obvious to the reader.
* the sequence point will order the write to p before mctp_rx() is
invoked, giving p the correct value at the time of invocation, but its
value after the return of mctp_rx() is undefined.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I68a1e35ba6a9b8daf89c4d5782037ed623ebbeb5
diff --git a/core.c b/core.c
index 0f7fb2f..6bcfd29 100644
--- a/core.c
+++ b/core.c
@@ -477,7 +477,7 @@
/* single-packet message - send straight up to rx function,
* no need to create a message context */
len = pkt->end - pkt->mctp_hdr_off - sizeof(struct mctp_hdr);
- p = pkt->data + pkt->mctp_hdr_off + sizeof(struct mctp_hdr),
+ p = pkt->data + pkt->mctp_hdr_off + sizeof(struct mctp_hdr);
mctp_rx(mctp, bus, hdr->src, hdr->dest, p, len);
break;