bootstrap: Ratchet up compiler strictness
Replace the specific warning flags with -Wall -Wextra and turn on
-Werror.
Covered by -Wall:
* -Wformat
* -Warray-bounds
* -Wimplicit-function-declaration
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iab21e67026d2453648aa6ebe4c299e1162fc5ebf
diff --git a/core.c b/core.c
index a46a733..95c38aa 100644
--- a/core.c
+++ b/core.c
@@ -67,8 +67,8 @@
#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
#endif
-static int mctp_message_tx_on_bus(struct mctp *mctp, struct mctp_bus *bus,
- mctp_eid_t src, mctp_eid_t dest, void *msg, size_t msg_len);
+static int mctp_message_tx_on_bus(struct mctp_bus *bus, mctp_eid_t src,
+ mctp_eid_t dest, void *msg, size_t msg_len);
struct mctp_pktbuf *mctp_pktbuf_alloc(struct mctp_binding *binding, size_t len)
{
@@ -240,9 +240,10 @@
void mctp_destroy(struct mctp *mctp)
{
- int i;
+ size_t i;
/* Cleanup message assembly contexts */
+ BUILD_ASSERT(ARRAY_SIZE(mctp->msg_ctxs) < SIZE_MAX);
for (i = 0; i < ARRAY_SIZE(mctp->msg_ctxs); i++) {
struct mctp_msg_ctx *tmp = &mctp->msg_ctxs[i];
if (tmp->buf)
@@ -320,9 +321,8 @@
(hdr->command_code <= MCTP_CTRL_CMD_LAST_TRANSPORT));
}
-static bool mctp_ctrl_handle_msg(struct mctp *mctp, struct mctp_bus *bus,
- mctp_eid_t src, mctp_eid_t dest, void *buffer,
- size_t length)
+static bool mctp_ctrl_handle_msg(struct mctp_bus *bus, mctp_eid_t src,
+ void *buffer, size_t length)
{
struct mctp_ctrl_msg_hdr *msg_hdr = buffer;
@@ -384,8 +384,8 @@
*/
if (mctp_ctrl_cmd_is_request(msg_hdr)) {
bool handled;
- handled = mctp_ctrl_handle_msg(mctp, bus, src,
- dest, buf, len);
+ handled = mctp_ctrl_handle_msg(bus, src, buf,
+ len);
if (handled)
return;
}
@@ -402,8 +402,7 @@
if (dest_bus == bus)
continue;
- mctp_message_tx_on_bus(mctp, dest_bus,
- src, dest, buf, len);
+ mctp_message_tx_on_bus(dest_bus, src, dest, buf, len);
}
}
@@ -551,8 +550,8 @@
mctp_send_tx_queue(bus);
}
-static int mctp_message_tx_on_bus(struct mctp *mctp, struct mctp_bus *bus,
- mctp_eid_t src, mctp_eid_t dest, void *msg, size_t msg_len)
+static int mctp_message_tx_on_bus(struct mctp_bus *bus, mctp_eid_t src,
+ mctp_eid_t dest, void *msg, size_t msg_len)
{
size_t max_payload_len, payload_len, p;
struct mctp_pktbuf *pkt;
@@ -613,5 +612,5 @@
struct mctp_bus *bus;
bus = find_bus_for_eid(mctp, eid);
- return mctp_message_tx_on_bus(mctp, bus, bus->eid, eid, msg, msg_len);
+ return mctp_message_tx_on_bus(bus, bus->eid, eid, msg, msg_len);
}