commit f1a2131017d2175bf995ab463b1392b221cda2a4
author Andrew Jeffery <andrew@aj.id.au> Fri May 22 12:48:21 2020 +0930
committer Andrew Jeffery <andrew@aj.id.au> Fri Jun 05 16:58:13 2020 +0930
tree 41e1fca24920893a5958c0ba93e04782dd42dac1
parent e756de86f3b54d97021d62cc2491bb2b9b6a798c

test_astlpc: Add astlpc_test_simple_init

Separate out testing of the basic transport initialisation sequence to
reduce use of asserts in other more extensive tests.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iad84d9fdb54ce0e895c1648206085f6d04e42c9b

tests/test_astlpc.c

diff --git a/tests/test_astlpc.c b/tests/test_astlpc.c
index c2cbba2..9e77b9e 100644
--- a/tests/test_astlpc.c
+++ b/tests/test_astlpc.c
@@ -194,25 +194,13 @@
 	endpoint_init(&bmc, 8, MCTP_BINDING_ASTLPC_MODE_BMC, &kcs, lpc_mem,
 		      lpc_size);
 
-	/* Verify the BMC binding was initialised */
-	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_BMC_READY);
-
 	/* Host initialisation */
 	endpoint_init(&host, 9, MCTP_BINDING_ASTLPC_MODE_HOST, &kcs, lpc_mem,
 		      lpc_size);
 
-	/* Host sends channel init command */
-	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_IBF);
-	assert(kcs[MCTP_ASTLPC_KCS_REG_DATA] == 0x00);
-
 	/* BMC receives host channel init request */
 	mctp_astlpc_poll(bmc.astlpc);
 
-	/* BMC sends init response */
-	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_OBF);
-	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_CHANNEL_ACTIVE);
-	assert(kcs[MCTP_ASTLPC_KCS_REG_DATA] == 0xff);
-
 	/* Host dequeues data */
 	mctp_astlpc_poll(host.astlpc);
 
@@ -249,10 +237,54 @@
 	free(lpc_mem);
 }
 
+static void astlpc_test_simple_init(void)
+{
+	struct astlpc_endpoint bmc, host;
+	uint8_t kcs[2] = { 0 };
+	size_t lpc_size;
+	void *lpc_mem;
+
+	/* Test harness initialisation */
+	lpc_size = 1 * 1024 * 1024;
+	lpc_mem = calloc(1, lpc_size);
+	assert(lpc_mem);
+
+	/* Bus owner (BMC) initialisation */
+	endpoint_init(&bmc, 8, MCTP_BINDING_ASTLPC_MODE_BMC, &kcs, lpc_mem,
+		      lpc_size);
+
+	/* Verify the BMC binding was initialised */
+	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_BMC_READY);
+
+	/* Device (Host) initialisation */
+	endpoint_init(&host, 9, MCTP_BINDING_ASTLPC_MODE_HOST, &kcs, lpc_mem,
+		      lpc_size);
+
+	/* Host sends channel init command */
+	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_IBF);
+	assert(kcs[MCTP_ASTLPC_KCS_REG_DATA] == 0x00);
+
+	/* BMC receives host channel init request */
+	mctp_astlpc_poll(bmc.astlpc);
+
+	/* BMC sends init response */
+	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_OBF);
+	assert(kcs[MCTP_ASTLPC_KCS_REG_STATUS] & KCS_STATUS_CHANNEL_ACTIVE);
+	assert(kcs[MCTP_ASTLPC_KCS_REG_DATA] == 0xff);
+
+	/* Host dequeues data */
+	mctp_astlpc_poll(host.astlpc);
+
+	endpoint_destroy(&bmc);
+	endpoint_destroy(&host);
+	free(lpc_mem);
+}
+
 int main(void)
 {
 	mctp_set_log_stdio(MCTP_LOG_DEBUG);
 
+	astlpc_test_simple_init();
 	astlpc_test_packetised_message_bmc_to_host();
 
 	return 0;