pdr: Stabilise pldm_entity_association_pdr_add_from_node_check()

pldm_entity_association_pdr_add_from_node_check() is a replacement for
pldm_entity_association_pdr_add_from_node(). The latter sanitized its
arguments with assert(), while the former instead returns a value
indicating success or error.

Use of pldm_entity_association_pdr_add_from_node_check() is demonstrated
here:

https://gerrit.openbmc.org/c/openbmc/pldm/+/64629

Additionally, deprecate pldm_entity_association_pdr_add_from_node() now
that there is a stable replacement.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If328d4e0ad395fffc01ee79b1a24904ee1de7edf
diff --git a/abi/aarch64/gcc.dump b/abi/aarch64/gcc.dump
index 660f9cf..dfd6c3a 100644
--- a/abi/aarch64/gcc.dump
+++ b/abi/aarch64/gcc.dump
@@ -6465,6 +6465,37 @@
                                          'Return' => '1',
                                          'ShortName' => 'pldm_find_entity_ref_in_tree'
                                        },
+                            '82785' => {
+                                         'Header' => 'pdr.h',
+                                         'Param' => {
+                                                      '0' => {
+                                                               'name' => 'node',
+                                                               'type' => '79226'
+                                                             },
+                                                      '1' => {
+                                                               'name' => 'repo',
+                                                               'type' => '81757'
+                                                             },
+                                                      '2' => {
+                                                               'name' => 'entities',
+                                                               'type' => '79988'
+                                                             },
+                                                      '3' => {
+                                                               'name' => 'num_entities',
+                                                               'type' => '123'
+                                                             },
+                                                      '4' => {
+                                                               'name' => 'is_remote',
+                                                               'type' => '6265'
+                                                             },
+                                                      '5' => {
+                                                               'name' => 'terminus_handle',
+                                                               'type' => '4895'
+                                                             }
+                                                    },
+                                         'Return' => '74',
+                                         'ShortName' => 'pldm_entity_association_pdr_add_from_node_check'
+                                       },
                             '83001' => {
                                          'Header' => 'pdr.h',
                                          'Param' => {
@@ -7691,6 +7722,7 @@
                                                  'pldm_bios_table_string_find_by_string' => 1,
                                                  'pldm_entity_association_pdr_add' => 1,
                                                  'pldm_entity_association_pdr_add_from_node' => 1,
+                                                 'pldm_entity_association_pdr_add_from_node_check' => 1,
                                                  'pldm_entity_association_pdr_extract' => 1,
                                                  'pldm_entity_association_tree_add' => 1,
                                                  'pldm_entity_association_tree_copy_root' => 1,