commit 1e0528c2fde23852ac16d3f321cb6e0a8cbcc7e2
author Andrew Jeffery <andrew@aj.id.au> Wed Apr 05 19:54:58 2023 +0930
committer Andrew Jeffery <andrew@aj.id.au> Thu Apr 06 03:17:55 2023 +0930
tree 6b43386d11239e4989f1ef05539edeb861361bfc
parent d2c64cbd53db38ded016e1d325cf7a9c18c9bf31

clang-tidy: Fix readability-else-after-return diagnostics

```
/usr/bin/clang-tidy -checks=-*, readability-else-after-return -export-fixes /tmp/tmp4f2o40d3/tmp18pyt1xg.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/requester/pldm.c
/mnt/host/andrew/src/openbmc/libpldm/build/../src/requester/pldm.c:64:4: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
        } else if (length < min_len) {
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I43dd1da00ed3192cccaf1001e2eb6031cee12a27

src/requester/pldm.c

diff --git a/src/requester/pldm.c b/src/requester/pldm.c
index 1dea225..4ec6d51 100644
--- a/src/requester/pldm.c
+++ b/src/requester/pldm.c
@@ -61,38 +61,36 @@
 	ssize_t length = recv(mctp_fd, NULL, 0, MSG_PEEK | MSG_TRUNC);
 	if (length <= 0) {
 		return PLDM_REQUESTER_RECV_FAIL;
-	} else if (length < min_len) {
+	}
+	if (length < min_len) {
 		/* read and discard */
 		uint8_t buf[length];
 		recv(mctp_fd, buf, length, 0);
 		return PLDM_REQUESTER_INVALID_RECV_LEN;
-	} else {
-		struct iovec iov[2];
-		size_t mctp_prefix_len =
-		    sizeof(eid) + sizeof(MCTP_MSG_TYPE_PLDM);
-		uint8_t mctp_prefix[mctp_prefix_len];
-		size_t pldm_len = length - mctp_prefix_len;
-		iov[0].iov_len = mctp_prefix_len;
-		iov[0].iov_base = mctp_prefix;
-		*pldm_resp_msg = malloc(pldm_len);
-		iov[1].iov_len = pldm_len;
-		iov[1].iov_base = *pldm_resp_msg;
-		struct msghdr msg = {0};
-		msg.msg_iov = iov;
-		msg.msg_iovlen = sizeof(iov) / sizeof(iov[0]);
-		ssize_t bytes = recvmsg(mctp_fd, &msg, 0);
-		if (length != bytes) {
-			free(*pldm_resp_msg);
-			return PLDM_REQUESTER_INVALID_RECV_LEN;
-		}
-		if ((mctp_prefix[0] != eid) ||
-		    (mctp_prefix[1] != MCTP_MSG_TYPE_PLDM)) {
-			free(*pldm_resp_msg);
-			return PLDM_REQUESTER_NOT_PLDM_MSG;
-		}
-		*resp_msg_len = pldm_len;
-		return PLDM_REQUESTER_SUCCESS;
 	}
+	struct iovec iov[2];
+	size_t mctp_prefix_len = sizeof(eid) + sizeof(MCTP_MSG_TYPE_PLDM);
+	uint8_t mctp_prefix[mctp_prefix_len];
+	size_t pldm_len = length - mctp_prefix_len;
+	iov[0].iov_len = mctp_prefix_len;
+	iov[0].iov_base = mctp_prefix;
+	*pldm_resp_msg = malloc(pldm_len);
+	iov[1].iov_len = pldm_len;
+	iov[1].iov_base = *pldm_resp_msg;
+	struct msghdr msg = {0};
+	msg.msg_iov = iov;
+	msg.msg_iovlen = sizeof(iov) / sizeof(iov[0]);
+	ssize_t bytes = recvmsg(mctp_fd, &msg, 0);
+	if (length != bytes) {
+		free(*pldm_resp_msg);
+		return PLDM_REQUESTER_INVALID_RECV_LEN;
+	}
+	if ((mctp_prefix[0] != eid) || (mctp_prefix[1] != MCTP_MSG_TYPE_PLDM)) {
+		free(*pldm_resp_msg);
+		return PLDM_REQUESTER_NOT_PLDM_MSG;
+	}
+	*resp_msg_len = pldm_len;
+	return PLDM_REQUESTER_SUCCESS;
 }
 
 pldm_requester_rc_t pldm_recv_any(mctp_eid_t eid, int mctp_fd,