pdr: Remove pldm_entity_association_pdr_add()

pldm_entity_association_pdr_add() was deprecated with the stabilisation
of pldm_entity_association_pdr_add_check() in 096685b4768e ("pdr:
Stabilise pldm_entity_association_pdr_add_check()"). We've had an
intervening tag, so remove it now

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I43df7451d3ed8d6c8f755e6bf23f335e2911184c
diff --git a/tests/libpldm_pdr_test.cpp b/tests/libpldm_pdr_test.cpp
index c2711c6..a6955a4 100644
--- a/tests/libpldm_pdr_test.cpp
+++ b/tests/libpldm_pdr_test.cpp
@@ -1211,7 +1211,8 @@
               1);
 
     auto repo = pldm_pdr_init();
-    pldm_entity_association_pdr_add(tree, repo, false, 1);
+    int rc = pldm_entity_association_pdr_add_check(tree, repo, false, 1);
+    ASSERT_EQ(rc, 0);
 
     EXPECT_EQ(pldm_pdr_get_record_count(repo), 6u);
 
@@ -1842,7 +1843,8 @@
               2);
 
     auto repo = pldm_pdr_init();
-    pldm_entity_association_pdr_add(tree, repo, false, 1);
+    int rc = pldm_entity_association_pdr_add_check(tree, repo, false, 1);
+    ASSERT_EQ(rc, 0);
 
     EXPECT_EQ(pldm_pdr_get_record_count(repo), 1u);