commit 2d66393f0d2f9c4acf21c18ef50e3e5f6eea60f8
author Andrew Jeffery <andrew@aj.id.au> Tue Jun 27 14:19:15 2023 +0930
committer Andrew Jeffery <andrew@aj.id.au> Fri Jun 30 10:10:22 2023 +0930
tree 435fac46cb38b99e15ad583b2a14149bd7b36fb4
parent 7aeb7edba6a1aba5573cfc291c24292bbc968a7b

bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_string()

Users should prefer
pldm_bios_table_attr_value_entry_encode_string_check() which returns an
error code rather than preventing misbehaviour via assert().

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id1aea49a07ac52858c1a5977e4f96b987f705064

tests/libpldm_bios_table_test.cpp

diff --git a/tests/libpldm_bios_table_test.cpp b/tests/libpldm_bios_table_test.cpp
index 6bf60a7..a7f5677 100644
--- a/tests/libpldm_bios_table_test.cpp
+++ b/tests/libpldm_bios_table_test.cpp
@@ -657,7 +657,7 @@
     EXPECT_DEATH(
         pldm_bios_table_attr_value_entry_encode_string(
             encodeEntry.data(), encodeEntry.size() - 1, 0, 1, 3, "abc"),
-        "length <= entry_length");
+        "rc == PLDM_SUCCESS");
 
     auto rc = pldm_bios_table_attr_value_entry_encode_string_check(
         encodeEntry.data(), encodeEntry.size(), 0, PLDM_BIOS_STRING, 3, "abc");