commit 3643e74d5d8f4759f125b10f7a95c91364dc3aa5
author Manojkiran Eda <manojkiran.eda@gmail.com> Mon May 19 12:03:54 2025 +0530
committer Andrew Jeffery <andrew@codeconstruct.com.au> Fri Jun 13 02:24:18 2025 +0000
tree 1d4bdd8c29a9d9c81ab22e8fc5208daff1de58bf
parent 412fa270c3999a38a911e84088a6b7a8ccf59121

fw_update: Use fw_update specific completion codes

`PLDM_INVALID_TRANSFER_OPERATION_FLAG` value as stated in base.h `0x21`
is incorrect as per the PLDM Base specification. Reduce its usage by
leveraging the FWUP specific completion codes for
encode_pass_component_table_req() command.

Change-Id: I679c90326ec4c150888e71f858a3375ee9f5ad29
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0a62ae8..5bec9cf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -44,6 +44,10 @@
 
 - pdr: Stabilize pldm_pdr_delete_by_record_handle()
 
+- fw_update: Return `PLDM_FWUP_INVALID_TRANSFER_OPERATION_FLAG` instead of
+  `PLDM_INVALID_TRANSFER_OPERATION_FLAG` in `encode_pass_component_table_req()`
+  command.
+
 ### Deprecated
 
 - utils: Deprecate `is_time_legal()`

src/dsp/firmware_update.c

diff --git a/src/dsp/firmware_update.c b/src/dsp/firmware_update.c
index 7534e3a..ea8cfd2 100644
--- a/src/dsp/firmware_update.c
+++ b/src/dsp/firmware_update.c
@@ -1892,7 +1892,7 @@
 	}
 
 	if (!is_transfer_flag_valid(transfer_flag)) {
-		return PLDM_INVALID_TRANSFER_OPERATION_FLAG;
+		return PLDM_FWUP_INVALID_TRANSFER_OPERATION_FLAG;
 	}
 
 	if (!is_string_type_valid(comp_ver_str_type)) {

tests/dsp/firmware_update.cpp

diff --git a/tests/dsp/firmware_update.cpp b/tests/dsp/firmware_update.cpp
index fa2d60c..05b8dd1 100644
--- a/tests/dsp/firmware_update.cpp
+++ b/tests/dsp/firmware_update.cpp
@@ -3255,7 +3255,7 @@
         compClassificationIndex, compComparisonStamp, PLDM_STR_TYPE_ASCII,
         compVerStrLen, &compVerStrInfo, requestMsg,
         sizeof(pldm_pass_component_table_req) + compVerStrLen);
-    EXPECT_EQ(rc, PLDM_INVALID_TRANSFER_OPERATION_FLAG);
+    EXPECT_EQ(rc, PLDM_FWUP_INVALID_TRANSFER_OPERATION_FLAG);
 
     rc = encode_pass_component_table_req(
         instanceId, PLDM_START_AND_END, PLDM_COMP_FIRMWARE, compIdentifier,