commit 46d0768577e9b2124d0f7ab2346e6ee03fbed5bd
author Andrew Jeffery <andrew@aj.id.au> Fri Jul 14 15:51:51 2023 +0930
committer Andrew Jeffery <andrew@aj.id.au> Wed Jul 19 15:54:02 2023 +0930
tree 42b349a53072b1b8cdda004cc9cf6d17f61b6ac0
parent 8b1c0340a3a8048f61c2112e2e8daa6e7a16bd32

bios_table: Remove pldm_bios_table_attr_value_entry_encode_string()

pldm_bios_table_attr_value_entry_encode_string() was deprecated in
v0.4.0, remove it now.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I0a2bd8eef2f70a40158060cd50c49aa4d0ec4d72

tests/libpldm_bios_table_test.cpp

diff --git a/tests/libpldm_bios_table_test.cpp b/tests/libpldm_bios_table_test.cpp
index 5746bd8..974ed19 100644
--- a/tests/libpldm_bios_table_test.cpp
+++ b/tests/libpldm_bios_table_test.cpp
@@ -651,14 +651,14 @@
     auto length = pldm_bios_table_attr_value_entry_encode_string_length(3);
     EXPECT_EQ(length, stringEntry.size());
     std::vector<uint8_t> encodeEntry(length, 0);
-    pldm_bios_table_attr_value_entry_encode_string(
-        encodeEntry.data(), encodeEntry.size(), 0, 1, 3, "abc");
+    ASSERT_EQ(pldm_bios_table_attr_value_entry_encode_string_check(
+                  encodeEntry.data(), encodeEntry.size(), 0, 1, 3, "abc"),
+              PLDM_SUCCESS);
     EXPECT_EQ(encodeEntry, stringEntry);
 
-    EXPECT_DEATH(
-        pldm_bios_table_attr_value_entry_encode_string(
-            encodeEntry.data(), encodeEntry.size() - 1, 0, 1, 3, "abc"),
-        "rc == PLDM_SUCCESS");
+    EXPECT_NE(pldm_bios_table_attr_value_entry_encode_string_check(
+                  encodeEntry.data(), encodeEntry.size() - 1, 0, 1, 3, "abc"),
+              PLDM_SUCCESS);
 
     auto rc = pldm_bios_table_attr_value_entry_encode_string_check(
         encodeEntry.data(), encodeEntry.size(), 0, PLDM_BIOS_STRING, 3, "abc");