dsp: bios_table: Rename pldm_bios_table_attr_entry_integer_encode_check()
Introduce pldm_bios_table_attr_entry_integer_encode(), deprecate
pldm_bios_table_attr_entry_integer_encode_check(), add rename
configuration and apply it.
gitlint-ignore: T1
Change-Id: I4ad074babfa33e661cb5b0791cc539453dbd27c7
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6e15eb7..47f9486 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -50,6 +50,7 @@
- `pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()`
- `pldm_bios_table_attr_entry_enum_decode_pv_num_check()`
- `pldm_bios_table_attr_entry_enum_encode_check()`
+ - `pldm_bios_table_attr_entry_integer_encode_check()`
- `pldm_bios_table_attr_entry_string_decode_def_string_length_check()`
- `pldm_bios_table_attr_entry_string_encode_check()`
- `pldm_bios_table_string_entry_decode_string_check()`
diff --git a/abi/x86_64/gcc.dump b/abi/x86_64/gcc.dump
index 3781c21..e7f6277 100644
--- a/abi/x86_64/gcc.dump
+++ b/abi/x86_64/gcc.dump
@@ -1598,7 +1598,7 @@
},
'17275' => {
'Header' => 'bios_table.h',
- 'Line' => '654',
+ 'Line' => '657',
'Param' => {
'0' => {
'name' => 'table',
@@ -1618,7 +1618,7 @@
},
'17420' => {
'Header' => 'bios_table.h',
- 'Line' => '645',
+ 'Line' => '648',
'Param' => {
'0' => {
'name' => 'src_table',
@@ -1654,7 +1654,7 @@
},
'18108' => {
'Header' => 'bios_table.h',
- 'Line' => '611',
+ 'Line' => '614',
'Param' => {
'0' => {
'name' => 'table',
@@ -1847,7 +1847,7 @@
},
'20598' => {
'Header' => 'bios_table.h',
- 'Line' => '630',
+ 'Line' => '633',
'Param' => {
'0' => {
'name' => 'table',
@@ -1872,7 +1872,7 @@
},
'20898' => {
'Header' => 'bios_table.h',
- 'Line' => '618',
+ 'Line' => '621',
'Param' => {
'0' => {
'name' => 'size_without_pad',
@@ -1884,7 +1884,7 @@
},
'21253' => {
'Header' => 'bios_table.h',
- 'Line' => '593',
+ 'Line' => '596',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1899,7 +1899,7 @@
},
'21302' => {
'Header' => 'bios_table.h',
- 'Line' => '600',
+ 'Line' => '603',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1911,7 +1911,7 @@
},
'21786' => {
'Header' => 'bios_table.h',
- 'Line' => '567',
+ 'Line' => '570',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1926,7 +1926,7 @@
},
'21926' => {
'Header' => 'bios_table.h',
- 'Line' => '583',
+ 'Line' => '586',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1961,13 +1961,13 @@
},
'22195' => {
'Header' => 'bios_table.h',
- 'Line' => '561',
+ 'Line' => '564',
'Return' => '1145',
'ShortName' => 'pldm_bios_table_attr_value_entry_encode_integer_length'
},
'22357' => {
'Header' => 'bios_table.h',
- 'Line' => '554',
+ 'Line' => '557',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2007,7 +2007,7 @@
},
'22757' => {
'Header' => 'bios_table.h',
- 'Line' => '535',
+ 'Line' => '538',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2023,7 +2023,7 @@
},
'22852' => {
'Header' => 'bios_table.h',
- 'Line' => '525',
+ 'Line' => '528',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2038,7 +2038,7 @@
},
'22993' => {
'Header' => 'bios_table.h',
- 'Line' => '519',
+ 'Line' => '522',
'Param' => {
'0' => {
'name' => 'string_length',
@@ -2053,7 +2053,7 @@
},
'23175' => {
'Header' => 'bios_table.h',
- 'Line' => '509',
+ 'Line' => '512',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2090,7 +2090,7 @@
},
'23494' => {
'Header' => 'bios_table.h',
- 'Line' => '490',
+ 'Line' => '493',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2110,7 +2110,7 @@
},
'23741' => {
'Header' => 'bios_table.h',
- 'Line' => '480',
+ 'Line' => '483',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2125,7 +2125,7 @@
},
'23790' => {
'Header' => 'bios_table.h',
- 'Line' => '474',
+ 'Line' => '477',
'Param' => {
'0' => {
'name' => 'count',
@@ -2140,7 +2140,7 @@
},
'23839' => {
'Header' => 'bios_table.h',
- 'Line' => '467',
+ 'Line' => '470',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2155,7 +2155,7 @@
},
'23888' => {
'Header' => 'bios_table.h',
- 'Line' => '460',
+ 'Line' => '463',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2170,7 +2170,7 @@
},
'24435' => {
'Header' => 'bios_table.h',
- 'Line' => '452',
+ 'Line' => '455',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2226,7 +2226,7 @@
'2' => 'rbx'
},
'Return' => '100',
- 'ShortName' => 'pldm_bios_table_attr_entry_integer_encode_check'
+ 'ShortName' => 'pldm_bios_table_attr_entry_integer_encode'
},
'24843' => {
'Header' => 'bios_table.h',
@@ -9468,6 +9468,7 @@
'pldm_bios_table_attr_entry_enum_encode_check' => 1,
'pldm_bios_table_attr_entry_enum_encode_length' => 1,
'pldm_bios_table_attr_entry_integer_decode' => 1,
+ 'pldm_bios_table_attr_entry_integer_encode' => 1,
'pldm_bios_table_attr_entry_integer_encode_check' => 1,
'pldm_bios_table_attr_entry_integer_encode_length' => 1,
'pldm_bios_table_attr_entry_integer_info_check' => 1,
diff --git a/evolutions/current/pldm_bios_table_attr_entry_integer_encode_check.yaml b/evolutions/current/pldm_bios_table_attr_entry_integer_encode_check.yaml
new file mode 100644
index 0000000..7f81ee3
--- /dev/null
+++ b/evolutions/current/pldm_bios_table_attr_entry_integer_encode_check.yaml
@@ -0,0 +1,2 @@
+- QualifiedName: pldm_bios_table_attr_entry_integer_encode_check
+ NewName: pldm_bios_table_attr_entry_integer_encode
diff --git a/include/libpldm/bios_table.h b/include/libpldm/bios_table.h
index d3cb76e..f5975d8 100644
--- a/include/libpldm/bios_table.h
+++ b/include/libpldm/bios_table.h
@@ -437,6 +437,9 @@
* in info is not logically consistent. PLDM_ERROR_INVALID_LENGTH if entry_length lacks
* capacity to encode the attribute.
*/
+int pldm_bios_table_attr_entry_integer_encode(
+ void *entry, size_t entry_length,
+ const struct pldm_bios_table_attr_entry_integer_info *info);
int pldm_bios_table_attr_entry_integer_encode_check(
void *entry, size_t entry_length,
const struct pldm_bios_table_attr_entry_integer_info *info);
diff --git a/meson.build b/meson.build
index bdeedd4..300191e 100644
--- a/meson.build
+++ b/meson.build
@@ -38,6 +38,7 @@
['pldm_bios_table_attr_entry_enum_decode_pv_hdls_check', 'pldm_bios_table_attr_entry_enum_decode_pv_hdls'],
['pldm_bios_table_attr_entry_enum_decode_pv_num_check', 'pldm_bios_table_attr_entry_enum_decode_pv_num'],
['pldm_bios_table_attr_entry_enum_encode_check', 'pldm_bios_table_attr_entry_enum_encode'],
+ ['pldm_bios_table_attr_entry_integer_encode_check', 'pldm_bios_table_attr_entry_integer_encode'],
['pldm_bios_table_attr_entry_string_decode_def_string_length_check', 'pldm_bios_table_attr_entry_string_decode_def_string_length'],
['pldm_bios_table_attr_entry_string_encode_check', 'pldm_bios_table_attr_entry_string_encode'],
['pldm_bios_table_string_entry_decode_string_check', 'pldm_bios_table_string_entry_decode_string'],
diff --git a/src/dsp/bios_table.c b/src/dsp/bios_table.c
index 60b1f6d..0aeee9a 100644
--- a/src/dsp/bios_table.c
+++ b/src/dsp/bios_table.c
@@ -543,7 +543,7 @@
}
LIBPLDM_ABI_STABLE
-int pldm_bios_table_attr_entry_integer_encode_check(
+int pldm_bios_table_attr_entry_integer_encode(
void *entry, size_t entry_length,
const struct pldm_bios_table_attr_entry_integer_info *info)
{
diff --git a/tests/dsp/bios_table.cpp b/tests/dsp/bios_table.cpp
index 6cef269..c9631af 100644
--- a/tests/dsp/bios_table.cpp
+++ b/tests/dsp/bios_table.cpp
@@ -363,7 +363,7 @@
EXPECT_EQ(encodeLength, integerEntry.size());
std::vector<uint8_t> encodeEntry(encodeLength, 0);
- ASSERT_EQ(pldm_bios_table_attr_entry_integer_encode_check(
+ ASSERT_EQ(pldm_bios_table_attr_entry_integer_encode(
encodeEntry.data(), encodeEntry.size(), &info),
PLDM_SUCCESS);
// set attr handle = 0
@@ -372,11 +372,11 @@
EXPECT_EQ(integerEntry, encodeEntry);
- EXPECT_NE(pldm_bios_table_attr_entry_integer_encode_check(
+ EXPECT_NE(pldm_bios_table_attr_entry_integer_encode(
encodeEntry.data(), encodeEntry.size() - 1, &info),
PLDM_SUCCESS);
- auto rc = pldm_bios_table_attr_entry_integer_encode_check(
+ auto rc = pldm_bios_table_attr_entry_integer_encode(
encodeEntry.data(), encodeEntry.size(), &info);
EXPECT_EQ(rc, PLDM_SUCCESS);
// set attr handle = 0
@@ -385,7 +385,7 @@
EXPECT_EQ(integerEntry, encodeEntry);
- rc = pldm_bios_table_attr_entry_integer_encode_check(
+ rc = pldm_bios_table_attr_entry_integer_encode(
encodeEntry.data(), encodeEntry.size() - 1, &info);
EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
@@ -395,8 +395,8 @@
rc = pldm_bios_table_attr_entry_integer_info_check(&info, &errmsg);
EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
EXPECT_STREQ("LowerBound should not be greater than UpperBound", errmsg);
- rc = pldm_bios_table_attr_entry_integer_encode_check(
- encodeEntry.data(), encodeEntry.size(), &info);
+ rc = pldm_bios_table_attr_entry_integer_encode(encodeEntry.data(),
+ encodeEntry.size(), &info);
EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
}