clang-tidy: Fix bugprone-branch-clone diagnostic
```
/usr/bin/clang-tidy -checks=-*, bugprone-branch-clone -export-fixes /tmp/tmplugxq7wz/tmpfx50asij.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/firmware_update.c
../src/firmware_update.c:245:49: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
aux_state_status == PLDM_FD_GENERIC_ERROR) {
^
../src/firmware_update.c:247:3: note: end of the original
} else if (aux_state_status >=
^
../src/firmware_update.c:249:66: note: clone 1 starts here
aux_state_status <= PLDM_FD_VENDOR_DEFINED_STATUS_CODE_END) {
^
```
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I7867b099bafb92da9547288b886273c470e1b81f
diff --git a/src/firmware_update.c b/src/firmware_update.c
index bd6ed9a..c5a213f 100644
--- a/src/firmware_update.c
+++ b/src/firmware_update.c
@@ -242,11 +242,9 @@
{
if (aux_state_status == PLDM_FD_AUX_STATE_IN_PROGRESS_OR_SUCCESS ||
aux_state_status == PLDM_FD_TIMEOUT ||
- aux_state_status == PLDM_FD_GENERIC_ERROR) {
- return true;
- } else if (aux_state_status >=
- PLDM_FD_VENDOR_DEFINED_STATUS_CODE_START &&
- aux_state_status <= PLDM_FD_VENDOR_DEFINED_STATUS_CODE_END) {
+ aux_state_status == PLDM_FD_GENERIC_ERROR ||
+ (aux_state_status >= PLDM_FD_VENDOR_DEFINED_STATUS_CODE_START &&
+ aux_state_status <= PLDM_FD_VENDOR_DEFINED_STATUS_CODE_END)) {
return true;
}