commit 6a97b79ebcfe4d91f8150d62b61e1a2fb2ac3a12
author Andrew Jeffery <andrew@codeconstruct.com.au> Mon Dec 09 13:46:51 2024 +1030
committer Andrew Jeffery <andrew@codeconstruct.com.au> Thu Dec 12 12:03:10 2024 +1030
tree 7f7567e12aa9fd3609149a375dd16ecc4e74a0a3
parent 0612d988bd12884bbb72a82377370b369f29ad01

dsp: firmware_update: Expand "params" in symbol names

Try to keep the names aligned with the spec so that they're more easily
searched for. We can abbreviate other words such as request, response,
length etc as necessary.

Change-Id: Ia5a2c93c153c70107be0fcddb1043b2e08cdd026
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

src/dsp/firmware_update.c

diff --git a/src/dsp/firmware_update.c b/src/dsp/firmware_update.c
index 59c5c20..c21c118 100644
--- a/src/dsp/firmware_update.c
+++ b/src/dsp/firmware_update.c
@@ -1112,9 +1112,9 @@
 }
 
 LIBPLDM_ABI_TESTING
-int encode_get_downstream_firmware_params_req(
+int encode_get_downstream_firmware_parameters_req(
 	uint8_t instance_id,
-	const struct pldm_get_downstream_firmware_params_req *params_req,
+	const struct pldm_get_downstream_firmware_parameters_req *params_req,
 	struct pldm_msg *msg, size_t payload_length)
 {
 	struct pldm_msgbuf _buf;
@@ -1126,7 +1126,7 @@
 	}
 
 	rc = pldm_msgbuf_init_errno(
-		buf, PLDM_GET_DOWNSTREAM_FIRMWARE_PARAMS_REQ_BYTES,
+		buf, PLDM_GET_DOWNSTREAM_FIRMWARE_PARAMETERS_REQ_BYTES,
 		msg->payload, payload_length);
 	if (rc < 0) {
 		return rc;
@@ -1156,9 +1156,9 @@
 }
 
 LIBPLDM_ABI_TESTING
-int decode_get_downstream_firmware_params_resp(
+int decode_get_downstream_firmware_parameters_resp(
 	const struct pldm_msg *msg, size_t payload_length,
-	struct pldm_get_downstream_firmware_params_resp *resp_data,
+	struct pldm_get_downstream_firmware_parameters_resp *resp_data,
 	struct variable_field *downstream_device_param_table)
 {
 	struct pldm_msgbuf _buf;
@@ -1184,7 +1184,8 @@
 		return 0;
 	}
 
-	if (payload_length < PLDM_GET_DOWNSTREAM_FIRMWARE_PARAMS_RESP_MIN_LEN) {
+	if (payload_length <
+	    PLDM_GET_DOWNSTREAM_FIRMWARE_PARAMETERS_RESP_MIN_LEN) {
 		return -EBADMSG;
 	}
 
@@ -1202,7 +1203,7 @@
 LIBPLDM_ABI_TESTING
 int decode_downstream_device_parameter_table_entry(
 	struct variable_field *data,
-	struct pldm_downstream_device_parameter_entry *entry,
+	struct pldm_downstream_device_parameters_entry *entry,
 	struct variable_field *versions)
 {
 	struct pldm_msgbuf _buf;
@@ -1216,7 +1217,7 @@
 	}
 
 	rc = pldm_msgbuf_init_errno(
-		buf, PLDM_DOWNSTREAM_DEVICE_PARAMETER_ENTRY_MIN_LEN, data->ptr,
+		buf, PLDM_DOWNSTREAM_DEVICE_PARAMETERS_ENTRY_MIN_LEN, data->ptr,
 		data->length);
 	if (rc < 0) {
 		return rc;
@@ -1285,7 +1286,7 @@
 LIBPLDM_ABI_TESTING
 int decode_downstream_device_parameter_table_entry_versions(
 	const struct variable_field *versions,
-	struct pldm_downstream_device_parameter_entry *entry, char *active,
+	struct pldm_downstream_device_parameters_entry *entry, char *active,
 	size_t active_len, char *pending, size_t pending_len)
 {
 	struct pldm_msgbuf _buf;