dsp: firmware_update: Change return type of downstream device ABI/APIs
So far all of the downstream device related ABI/APIs were marked as
`TESTING`, before stabilize them, any deprecated code should be
removed, including PLDM Completion Code, therefore, change all of the
return type of these to `ERRNO`.
Change-Id: Ie6b390fcc1c91a425f9181ec4ce4495729baab51
Signed-off-by: Unive Tien <unive.tien.wiwynn@gmail.com>
diff --git a/tests/dsp/firmware_update.cpp b/tests/dsp/firmware_update.cpp
index 878ba75..6fc1aa9 100644
--- a/tests/dsp/firmware_update.cpp
+++ b/tests/dsp/firmware_update.cpp
@@ -1316,7 +1316,7 @@
auto rc = encode_query_downstream_devices_req(instanceId, requestPtr);
- EXPECT_EQ(rc, PLDM_SUCCESS);
+ EXPECT_EQ(rc, 0);
EXPECT_EQ(requestPtr->hdr.request, PLDM_REQUEST);
EXPECT_EQ(requestPtr->hdr.instance_id, instanceId);
EXPECT_EQ(requestPtr->hdr.type, PLDM_FWUP);
@@ -1331,7 +1331,7 @@
auto rc = encode_query_downstream_devices_req(instanceId, nullptr);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
+ EXPECT_EQ(rc, -EINVAL);
}
#endif
@@ -1372,7 +1372,7 @@
rc = decode_query_downstream_devices_resp(
response, responseMsg.size() - hdrSize, &resp_data);
- EXPECT_EQ(rc, PLDM_SUCCESS);
+ EXPECT_EQ(rc, 0);
EXPECT_EQ(resp_data.completion_code, completion_code_resp);
EXPECT_EQ(resp_data.downstream_device_update_supported,
downstream_device_update_supported_resp);
@@ -1420,7 +1420,7 @@
rc = decode_query_downstream_devices_resp(
response, responseMsg.size() - hdrSize, &resp_data);
- ASSERT_EQ(rc, PLDM_ERROR_INVALID_DATA);
+ ASSERT_EQ(rc, -EINVAL);
}
#endif
@@ -1463,7 +1463,7 @@
rc = decode_query_downstream_devices_resp(
response, responseMsg.size() - hdrSize, &resp_data);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
+ EXPECT_EQ(rc, -EBADMSG);
}
#endif
@@ -1479,7 +1479,7 @@
auto rc = encode_query_downstream_identifiers_req(
instanceId, dataTransferHandle, transferOperationFlag, request,
payloadLen);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_THAT(std::span<uint8_t>(request_buf, sizeof(request_buf)),
ElementsAreArray<uint8_t>(
{0x81, 0x05, 0x04, 0xFF, 0xFF, 0xFF, 0xFF, 0x01}));
@@ -1503,17 +1503,17 @@
auto rc = encode_query_downstream_identifiers_req(
instanceId, dataTransferHandle, transferOperationFlag, nullptr,
payload_length);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
+ EXPECT_EQ(rc, -EINVAL);
rc = encode_query_downstream_identifiers_req(
instanceId, dataTransferHandle, transferOperationFlag, requestPtr,
payload_length - 1);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
+ EXPECT_EQ(rc, -EOVERFLOW);
rc = encode_query_downstream_identifiers_req(instanceId, dataTransferHandle,
invalidTransferOperationFlag,
requestPtr, payload_length);
- EXPECT_EQ(rc, PLDM_INVALID_TRANSFER_OPERATION_FLAG);
+ EXPECT_EQ(rc, -EINVAL);
}
#endif
@@ -1549,7 +1549,7 @@
response, PLDM_QUERY_DOWNSTREAM_IDENTIFIERS_RESP_MIN_LEN, &resp_data,
&devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_EQ(resp_data.completion_code, completion_code_resp);
EXPECT_EQ(resp_data.next_data_transfer_handle,
next_data_transfer_handle_resp);
@@ -1592,7 +1592,7 @@
rc = decode_query_downstream_identifiers_resp(
response, PLDM_QUERY_DOWNSTREAM_IDENTIFIERS_RESP_MIN_LEN, &resp, &devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
foreach_pldm_downstream_device(devs, dev, rc)
{
@@ -1646,7 +1646,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_EQ(resp_data.completion_code, completion_code_resp);
EXPECT_EQ(resp_data.next_data_transfer_handle,
next_data_transfer_handle_resp);
@@ -1750,7 +1750,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_EQ(resp_data.number_of_downstream_devices,
number_of_downstream_devices_resp);
@@ -1870,7 +1870,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_EQ(resp_data.number_of_downstream_devices,
number_of_downstream_devices_resp);
@@ -1990,7 +1990,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- ASSERT_EQ(rc, PLDM_SUCCESS);
+ ASSERT_EQ(rc, 0);
EXPECT_EQ(resp_data.number_of_downstream_devices,
number_of_downstream_devices_resp);
@@ -2048,13 +2048,13 @@
// Test nullptr
auto rc = decode_query_downstream_identifiers_resp(nullptr, payloadLen,
nullptr, &devs);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
+ EXPECT_EQ(rc, -EINVAL);
// Test not PLDM_SUCCESS completion code
response->payload[0] = PLDM_ERROR_UNSUPPORTED_PLDM_CMD;
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- EXPECT_EQ(rc, PLDM_SUCCESS);
+ EXPECT_EQ(rc, 0);
EXPECT_EQ(resp_data.completion_code, PLDM_ERROR_UNSUPPORTED_PLDM_CMD);
// Test payload length less than minimum length
@@ -2062,7 +2062,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
+ EXPECT_EQ(rc, -EBADMSG);
}
#endif
@@ -2110,7 +2110,7 @@
EXPECT_NE(decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs),
- PLDM_SUCCESS);
+ 0);
}
#endif
@@ -2148,7 +2148,7 @@
rc = decode_query_downstream_identifiers_resp(response, payloadLen,
&resp_data, &devs);
- EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
+ EXPECT_EQ(rc, -EBADMSG);
}
#endif