dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()
Introduce pldm_bios_table_attr_entry_enum_decode_pv_hdls(), deprecate
pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(), add the rename
configuration and apply it.
gitlint-ignore: T1
Change-Id: I29b4d24ce0bbb92ff0491c2abae4b512d4374e74
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2f346ea..88f1199 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -47,6 +47,7 @@
- `get_fru_record_by_option_check()`
- `pldm_bios_table_attr_entry_enum_decode_def_num_check()`
+ - `pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()`
- `pldm_bios_table_attr_entry_enum_decode_pv_num_check()`
- `pldm_bios_table_attr_entry_enum_encode_check()`
- `pldm_bios_table_string_entry_decode_string_check()`
diff --git a/abi/x86_64/gcc.dump b/abi/x86_64/gcc.dump
index 40c493e..09ea622 100644
--- a/abi/x86_64/gcc.dump
+++ b/abi/x86_64/gcc.dump
@@ -1598,7 +1598,7 @@
},
'17275' => {
'Header' => 'bios_table.h',
- 'Line' => '645',
+ 'Line' => '648',
'Param' => {
'0' => {
'name' => 'table',
@@ -1618,7 +1618,7 @@
},
'17420' => {
'Header' => 'bios_table.h',
- 'Line' => '636',
+ 'Line' => '639',
'Param' => {
'0' => {
'name' => 'src_table',
@@ -1654,7 +1654,7 @@
},
'18108' => {
'Header' => 'bios_table.h',
- 'Line' => '602',
+ 'Line' => '605',
'Param' => {
'0' => {
'name' => 'table',
@@ -1847,7 +1847,7 @@
},
'20598' => {
'Header' => 'bios_table.h',
- 'Line' => '621',
+ 'Line' => '624',
'Param' => {
'0' => {
'name' => 'table',
@@ -1872,7 +1872,7 @@
},
'20898' => {
'Header' => 'bios_table.h',
- 'Line' => '609',
+ 'Line' => '612',
'Param' => {
'0' => {
'name' => 'size_without_pad',
@@ -1884,7 +1884,7 @@
},
'21253' => {
'Header' => 'bios_table.h',
- 'Line' => '584',
+ 'Line' => '587',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1899,7 +1899,7 @@
},
'21302' => {
'Header' => 'bios_table.h',
- 'Line' => '591',
+ 'Line' => '594',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1911,7 +1911,7 @@
},
'21786' => {
'Header' => 'bios_table.h',
- 'Line' => '558',
+ 'Line' => '561',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1926,7 +1926,7 @@
},
'21926' => {
'Header' => 'bios_table.h',
- 'Line' => '574',
+ 'Line' => '577',
'Param' => {
'0' => {
'name' => 'entry',
@@ -1961,13 +1961,13 @@
},
'22195' => {
'Header' => 'bios_table.h',
- 'Line' => '552',
+ 'Line' => '555',
'Return' => '1145',
'ShortName' => 'pldm_bios_table_attr_value_entry_encode_integer_length'
},
'22357' => {
'Header' => 'bios_table.h',
- 'Line' => '545',
+ 'Line' => '548',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2007,7 +2007,7 @@
},
'22757' => {
'Header' => 'bios_table.h',
- 'Line' => '526',
+ 'Line' => '529',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2023,7 +2023,7 @@
},
'22852' => {
'Header' => 'bios_table.h',
- 'Line' => '516',
+ 'Line' => '519',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2038,7 +2038,7 @@
},
'22993' => {
'Header' => 'bios_table.h',
- 'Line' => '510',
+ 'Line' => '513',
'Param' => {
'0' => {
'name' => 'string_length',
@@ -2053,7 +2053,7 @@
},
'23175' => {
'Header' => 'bios_table.h',
- 'Line' => '500',
+ 'Line' => '503',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2090,7 +2090,7 @@
},
'23494' => {
'Header' => 'bios_table.h',
- 'Line' => '481',
+ 'Line' => '484',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2110,7 +2110,7 @@
},
'23741' => {
'Header' => 'bios_table.h',
- 'Line' => '471',
+ 'Line' => '474',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2125,7 +2125,7 @@
},
'23790' => {
'Header' => 'bios_table.h',
- 'Line' => '465',
+ 'Line' => '468',
'Param' => {
'0' => {
'name' => 'count',
@@ -2140,7 +2140,7 @@
},
'23839' => {
'Header' => 'bios_table.h',
- 'Line' => '458',
+ 'Line' => '461',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2155,7 +2155,7 @@
},
'23888' => {
'Header' => 'bios_table.h',
- 'Line' => '451',
+ 'Line' => '454',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2170,7 +2170,7 @@
},
'24435' => {
'Header' => 'bios_table.h',
- 'Line' => '443',
+ 'Line' => '446',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2205,7 +2205,7 @@
},
'24571' => {
'Header' => 'bios_table.h',
- 'Line' => '431',
+ 'Line' => '434',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2230,7 +2230,7 @@
},
'24843' => {
'Header' => 'bios_table.h',
- 'Line' => '412',
+ 'Line' => '415',
'Param' => {
'0' => {
'name' => 'info',
@@ -2246,13 +2246,13 @@
},
'25147' => {
'Header' => 'bios_table.h',
- 'Line' => '419',
+ 'Line' => '422',
'Return' => '1145',
'ShortName' => 'pldm_bios_table_attr_entry_integer_encode_length'
},
'25309' => {
'Header' => 'bios_table.h',
- 'Line' => '386',
+ 'Line' => '389',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2272,7 +2272,7 @@
},
'25578' => {
'Header' => 'bios_table.h',
- 'Line' => '378',
+ 'Line' => '381',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2287,7 +2287,7 @@
},
'25647' => {
'Header' => 'bios_table.h',
- 'Line' => '370',
+ 'Line' => '373',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2302,7 +2302,7 @@
},
'25716' => {
'Header' => 'bios_table.h',
- 'Line' => '362',
+ 'Line' => '365',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2317,7 +2317,7 @@
},
'25785' => {
'Header' => 'bios_table.h',
- 'Line' => '354',
+ 'Line' => '357',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2337,7 +2337,7 @@
},
'25955' => {
'Header' => 'bios_table.h',
- 'Line' => '343',
+ 'Line' => '346',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2361,7 +2361,7 @@
},
'26319' => {
'Header' => 'bios_table.h',
- 'Line' => '322',
+ 'Line' => '325',
'Param' => {
'0' => {
'name' => 'info',
@@ -2380,7 +2380,7 @@
},
'26588' => {
'Header' => 'bios_table.h',
- 'Line' => '330',
+ 'Line' => '333',
'Param' => {
'0' => {
'name' => 'def_str_len',
@@ -2395,7 +2395,7 @@
},
'26838' => {
'Header' => 'bios_table.h',
- 'Line' => '296',
+ 'Line' => '299',
'Param' => {
'0' => {
'name' => 'entry',
@@ -2440,7 +2440,7 @@
'2' => 'rdx'
},
'Return' => '100',
- 'ShortName' => 'pldm_bios_table_attr_entry_enum_decode_pv_hdls_check'
+ 'ShortName' => 'pldm_bios_table_attr_entry_enum_decode_pv_hdls'
},
'27300' => {
'Header' => 'bios_table.h',
@@ -9457,6 +9457,7 @@
'pldm_bios_table_attr_entry_enum_decode_def_indices' => 1,
'pldm_bios_table_attr_entry_enum_decode_def_num' => 1,
'pldm_bios_table_attr_entry_enum_decode_def_num_check' => 1,
+ 'pldm_bios_table_attr_entry_enum_decode_pv_hdls' => 1,
'pldm_bios_table_attr_entry_enum_decode_pv_hdls_check' => 1,
'pldm_bios_table_attr_entry_enum_decode_pv_num' => 1,
'pldm_bios_table_attr_entry_enum_decode_pv_num_check' => 1,
@@ -10395,7 +10396,7 @@
},
'16385' => {
'Header' => 'bios_table.h',
- 'Line' => '306',
+ 'Line' => '309',
'Memb' => {
'0' => {
'name' => 'name_handle',
@@ -10445,7 +10446,7 @@
},
'16507' => {
'Header' => 'bios_table.h',
- 'Line' => '396',
+ 'Line' => '399',
'Memb' => {
'0' => {
'name' => 'name_handle',
diff --git a/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml b/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml
new file mode 100644
index 0000000..ebac3e9
--- /dev/null
+++ b/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml
@@ -0,0 +1,2 @@
+- QualifiedName: pldm_bios_table_attr_entry_enum_decode_pv_hdls_check
+ NewName: pldm_bios_table_attr_entry_enum_decode_pv_hdls
diff --git a/include/libpldm/bios_table.h b/include/libpldm/bios_table.h
index 0f24a86..a0c86e3 100644
--- a/include/libpldm/bios_table.h
+++ b/include/libpldm/bios_table.h
@@ -281,6 +281,9 @@
* pldm_bios_table_attr_entry_enum_decode_pv_num_check, in which case only the first pv_num
* handles will be decoded.
*/
+int pldm_bios_table_attr_entry_enum_decode_pv_hdls(
+ const struct pldm_bios_attr_table_entry *entry, uint16_t *pv_hdls,
+ uint8_t pv_num);
int pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
const struct pldm_bios_attr_table_entry *entry, uint16_t *pv_hdls,
uint8_t pv_num);
diff --git a/meson.build b/meson.build
index 674d1ce..6d09983 100644
--- a/meson.build
+++ b/meson.build
@@ -35,6 +35,7 @@
libpldm_deprecated_aliases += [
['get_fru_record_by_option_check', 'get_fru_record_by_option'],
['pldm_bios_table_attr_entry_enum_decode_def_num_check', 'pldm_bios_table_attr_entry_enum_decode_def_num'],
+ ['pldm_bios_table_attr_entry_enum_decode_pv_hdls_check', 'pldm_bios_table_attr_entry_enum_decode_pv_hdls'],
['pldm_bios_table_attr_entry_enum_decode_pv_num_check', 'pldm_bios_table_attr_entry_enum_decode_pv_num'],
['pldm_bios_table_attr_entry_enum_encode_check', 'pldm_bios_table_attr_entry_enum_encode'],
['pldm_bios_table_string_entry_decode_string_check', 'pldm_bios_table_string_entry_decode_string'],
diff --git a/src/dsp/bios_table.c b/src/dsp/bios_table.c
index ad1b2a0..3f170f9 100644
--- a/src/dsp/bios_table.c
+++ b/src/dsp/bios_table.c
@@ -258,7 +258,7 @@
}
LIBPLDM_ABI_STABLE
-int pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
+int pldm_bios_table_attr_entry_enum_decode_pv_hdls(
const struct pldm_bios_attr_table_entry *entry, uint16_t *pv_hdls,
uint8_t pv_num)
{
diff --git a/tests/dsp/bios_table.cpp b/tests/dsp/bios_table.cpp
index 37c1a09..9d7aea5 100644
--- a/tests/dsp/bios_table.cpp
+++ b/tests/dsp/bios_table.cpp
@@ -83,26 +83,26 @@
EXPECT_EQ(pvNumber, 2);
std::vector<uint16_t> pvHandles(pvNumber, 0);
- ASSERT_EQ(pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
+ ASSERT_EQ(pldm_bios_table_attr_entry_enum_decode_pv_hdls(
entry, pvHandles.data(), pvHandles.size()),
PLDM_SUCCESS);
EXPECT_EQ(pvNumber, 2);
EXPECT_EQ(pvHandles[0], 2);
EXPECT_EQ(pvHandles[1], 3);
pvHandles.resize(1);
- ASSERT_EQ(pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
+ ASSERT_EQ(pldm_bios_table_attr_entry_enum_decode_pv_hdls(
entry, pvHandles.data(), pvHandles.size()),
PLDM_SUCCESS);
EXPECT_EQ(pvHandles[0], 2);
pvHandles.resize(2);
- rc = pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
- entry, pvHandles.data(), pvHandles.size());
+ rc = pldm_bios_table_attr_entry_enum_decode_pv_hdls(entry, pvHandles.data(),
+ pvHandles.size());
EXPECT_EQ(rc, PLDM_SUCCESS);
EXPECT_EQ(pvHandles[0], 2);
EXPECT_EQ(pvHandles[1], 3);
- rc = pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(
- entry, pvHandles.data(), 1);
+ rc = pldm_bios_table_attr_entry_enum_decode_pv_hdls(entry, pvHandles.data(),
+ 1);
EXPECT_EQ(rc, PLDM_SUCCESS);
uint8_t defNumber;
@@ -131,8 +131,7 @@
rc = pldm_bios_table_attr_entry_enum_decode_def_num(entry, &defNumber);
EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
- rc =
- pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(entry, nullptr, 0);
+ rc = pldm_bios_table_attr_entry_enum_decode_pv_hdls(entry, nullptr, 0);
EXPECT_EQ(rc, PLDM_ERROR_INVALID_DATA);
}