commit 98c1e69d58e76d31114fa118a5ebf08473096044
author Andrew Jeffery <andrew@aj.id.au> Wed Jun 14 14:41:19 2023 +0930
committer Andrew Jeffery <andrew@aj.id.au> Mon Jun 19 15:58:03 2023 +0930
tree 414343ca9eaeee5ae154531cf072ae07dc7d282d
parent df02e36029bede81b3c8de2b83ae33e6c1ae3d6e

bios_table: Relax pldm_bios_table_string_entry_decode_string_check()

Allow the string decoded by
pldm_bios_table_string_entry_decode_string_check() to be truncated, as
per the unchecked pldm_bios_table_string_entry_decode_string(). With
this change pldm_bios_table_string_entry_decode_string_check() provides
assert() safety but is otherwise equivalent.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia872f1496c642efbb34ee3ae29455f4eaf574082

tests/libpldm_bios_table_test.cpp

diff --git a/tests/libpldm_bios_table_test.cpp b/tests/libpldm_bios_table_test.cpp
index 4cefa30..c677b99 100644
--- a/tests/libpldm_bios_table_test.cpp
+++ b/tests/libpldm_bios_table_test.cpp
@@ -1006,9 +1006,10 @@
     EXPECT_EQ(rc, PLDM_SUCCESS);
     EXPECT_EQ(std::strcmp("Allowed", buffer.data()), 0);
 
-    rc = pldm_bios_table_string_entry_decode_string_check(entry, buffer.data(),
-                                                          buffer.size() - 1);
-    EXPECT_EQ(rc, PLDM_ERROR_INVALID_LENGTH);
+    /* Ensure equivalence with the unchecked API */
+    rc = pldm_bios_table_string_entry_decode_string_check(
+        entry, buffer.data(), 2 + 1 /* sizeof '\0' */);
+    EXPECT_EQ(rc, std::strcmp("Al", buffer.data()));
 }
 
 TEST(StringTable, IteratorTest)