tree 18b23616ea7cde3c4d6887e75b6e1f7e8e6c9cac
parent e21df505203b063ecf94de26aade4ba9b3bdba51
author Andrew Jeffery <andrew@aj.id.au> 1680670932 +0930
committer Andrew Jeffery <andrew@aj.id.au> 1680693284 +0930

utils: Reimplement ver2str() for sanity

The dense mix of print_version_field(), snprintf() with its tricky
return semantics, and the tricky POINTER_MOVE() macro are replaced by an
implementation where each statement directly inserts one character into
the buffer while preventing buffer overflow.

While we're reworking ver2str(), change the return type to avoid
clang-tidy's bugprone-narrowing-conversion diagnostic. This is an
API/ABI break, but it's one with low impact: The test suite declares the
variable holding the return type as `auto`, while the one ver2str() call
in the entire openbmc github org, in pldmd, immediately discards the
return value (it is never assigned).

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I11708a32019a36ea0d31229f6c91c8a75f7f22d0