commit c144ea91d1a41ea03ad95267dfb7943b2431ec24
author Andrew Jeffery <andrew@codeconstruct.com.au> Tue Sep 16 14:07:22 2025 +0930
committer Andrew Jeffery <andrew@codeconstruct.com.au> Tue Sep 16 14:09:48 2025 +0930
tree 0ea5dbcda1be5e198550bf6e0541b13f8b1b7539
parent d17265a10f8ecf2ed65ed0ba7f7f95a73b2bd062

tests: dsp: firmware_update: Drop guards for package parsing tests

These are now marked stable and shouldn't be conditionally compiled.

Fixes:

```
../tests/dsp/firmware_update.cpp:53:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_1' [-Werror,-Wunused-const-variable]
   53 |     PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_1{
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/dsp/firmware_update.cpp:59:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_2' [-Werror,-Wunused-const-variable]
   59 |     PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_2{0x31, 0x19, 0xce, 0x2f, 0xe8, 0x0a,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/dsp/firmware_update.cpp:64:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_3' [-Werror,-Wunused-const-variable]
   64 |     PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_3{0x7b, 0x29, 0x1c, 0x99, 0x6d, 0xb6,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Fixes: f6ef78f676a9 ("dsp: firmware_update: Stabilized new firmware package parsing ABI")
Change-Id: I3386d3827b80d31cb702cb9f3f67d616b09be478
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

tests/dsp/firmware_update.cpp

diff --git a/tests/dsp/firmware_update.cpp b/tests/dsp/firmware_update.cpp
index 0fbd693..a84a125 100644
--- a/tests/dsp/firmware_update.cpp
+++ b/tests/dsp/firmware_update.cpp
@@ -5152,7 +5152,6 @@
     EXPECT_EQ(nr_infos, 1);
 }
 
-#ifdef LIBPLDM_API_TESTING
 TEST(DecodePldmFirmwareUpdatePackage, invalidDownstreamDeviceIteration)
 {
     const std::array<uint8_t, 102> package{
@@ -5254,9 +5253,7 @@
     foreach_pldm_package_downstream_device_id_record(pkg, ddrec, rc)
         EXPECT_NE(rc, 0);
 }
-#endif
 
-#ifdef LIBPLDM_API_TESTING
 TEST(DecodePldmFirmwareUpdatePackage, p2v1h1fd1fdd1cii)
 {
     const std::array<uint8_t, 102> package{
@@ -6108,9 +6105,7 @@
 
     EXPECT_EQ(nr_infos, 2);
 }
-#endif
 
-#ifdef LIBPLDM_API_TESTING
 TEST(DecodePldmFirmwareUpdatePackage, downstreamDeviceBeforeFirmwareDevice)
 {
     const std::array<uint8_t, 182> package{
@@ -6162,9 +6157,7 @@
     }
     EXPECT_NE(rc, 0);
 }
-#endif
 
-#ifdef LIBPLDM_API_TESTING
 TEST(DecodePldmFirmwareUpdatePackage, componentImageInfosBeforeFirmwareDevice)
 {
     const std::array<uint8_t, 182> package{
@@ -6216,9 +6209,7 @@
     }
     EXPECT_NE(rc, 0);
 }
-#endif
 
-#ifdef LIBPLDM_API_TESTING
 TEST(DecodePldmFirmwareUpdatePackage,
      p4v2ComponentImageInfosBeforeDownstreamDevice)
 {
@@ -6284,4 +6275,3 @@
     }
     EXPECT_NE(rc, 0);
 }
-#endif