clang-tidy: NOLINT reserved identifiers
fix clang-tidy error in CI. Experienced this error on an unrelated code
change [1]
```
/data0/jenkins/workspace/ci-repository/openbmc/libpldm/include/libpldm/firmware_update.h:2298:8: error: declaration uses identifier 'pldm__package_header_information', which is a reserved identifier [bugprone-reserved-identifier,cert-dcl37-c,cert-dcl51-cpp,-warnings-as-errors]
2298 | struct pldm__package_header_information {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pldm_package_header_information
2299 | pldm_uuid package_header_identifier;
2300 | uint8_t package_header_format_revision;
2301 | uint8_t package_release_date_time[PLDM_TIMESTAMP104_SIZE];
2302 | uint16_t component_bitmap_bit_length;
2303 | uint8_t package_version_string_type;
2304 |
2305 | /** A field pointing to the package version string in the provided package data */
2306 | struct variable_field package_version_string;
2307 | };
2308 | /* TODO: Deprecate the other struct pldm_package_header_information, remove, drop typedef */
2309 | typedef struct pldm__package_header_information
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pldm_package_header_information
```
References:
[1] https://jenkins.openbmc.org/job/ci-repository/115058//console
Change-Id: I3e9dee5e266ee734f86039fc08dc28983d48c267
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3675ea..cf51303 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -65,6 +65,7 @@
- Reworked the firmware update package parsing APIs to track parse state using a
run-time state machine
- Add flags parameter to `decode_pldm_firmware_update_package()`
+- Add NOLINT to `pldm__package_header_information` to prevent clang-tidy errors.
### Deprecated
diff --git a/include/libpldm/firmware_update.h b/include/libpldm/firmware_update.h
index d7b58e8..bafae30 100644
--- a/include/libpldm/firmware_update.h
+++ b/include/libpldm/firmware_update.h
@@ -2295,6 +2295,7 @@
*
* The provided package data must out-live the header struct.
*/
+// NOLINTNEXTLINE(bugprone-reserved-identifier, cert-dcl37-c, cert-dcl51-cpp)
struct pldm__package_header_information {
pldm_uuid package_header_identifier;
uint8_t package_header_format_revision;
@@ -2306,6 +2307,7 @@
struct variable_field package_version_string;
};
/* TODO: Deprecate the other struct pldm_package_header_information, remove, drop typedef */
+// NOLINTNEXTLINE(bugprone-reserved-identifier, cert-dcl37-c, cert-dcl51-cpp)
typedef struct pldm__package_header_information
pldm_package_header_information_pad;