commit d2f8a7e3b37634ec0e42230a8ad14411f34e9149
author Unive Tien <unive.tien.wiwynn@gmail.com> Wed Nov 27 10:59:34 2024 +0800
committer Unive Tien <unive.tien.wiwynn@gmail.com> Thu Dec 05 14:43:08 2024 +0800
tree 88e66810106837c4c25969dde1c20beceb149a50
parent 71e935cfd4b83e8a2afa8724a8a3b24fd704d90e

dsp: firmware_update: pack decomposed parameters to struct

There're two APIs that have decomposed parameters:
`encode_query_downstream_identifiers_req()` and
`encode_get_downstream_firmware_params_req(),
which against the checklist of API/ABI stabilization,
squashed those parameters to a struct to meet the request.

Change-Id: Ia952251cf8dcaeba060985e759e1d7aadf7b5b4d
Signed-off-by: Unive Tien <unive.tien.wiwynn@gmail.com>

src/dsp/firmware_update.c

diff --git a/src/dsp/firmware_update.c b/src/dsp/firmware_update.c
index d2b068a..59c5c20 100644
--- a/src/dsp/firmware_update.c
+++ b/src/dsp/firmware_update.c
@@ -980,19 +980,21 @@
 
 LIBPLDM_ABI_TESTING
 int encode_query_downstream_identifiers_req(
-	uint8_t instance_id, uint32_t data_transfer_handle,
-	enum transfer_op_flag transfer_operation_flag, struct pldm_msg *msg,
-	size_t payload_length)
+	uint8_t instance_id,
+	const struct pldm_query_downstream_identifiers_req *params_req,
+	struct pldm_msg *msg, size_t payload_length)
 {
 	struct pldm_msgbuf _buf;
 	struct pldm_msgbuf *buf = &_buf;
 	int rc;
 
-	if (msg == NULL) {
+	if (!msg || !params_req) {
 		return -EINVAL;
 	}
 
-	if (!is_transfer_operation_flag_valid(transfer_operation_flag)) {
+	if (!is_transfer_operation_flag_valid(
+		    (enum transfer_op_flag)
+			    params_req->transfer_operation_flag)) {
 		return -EINVAL;
 	}
 
@@ -1013,9 +1015,9 @@
 		return rc;
 	}
 
-	pldm_msgbuf_insert(buf, data_transfer_handle);
+	pldm_msgbuf_insert(buf, params_req->data_transfer_handle);
 	// Data correctness has been verified, cast it to 1-byte data directly.
-	pldm_msgbuf_insert(buf, (uint8_t)transfer_operation_flag);
+	pldm_msgbuf_insert(buf, params_req->transfer_operation_flag);
 
 	return pldm_msgbuf_destroy(buf);
 }
@@ -1111,15 +1113,15 @@
 
 LIBPLDM_ABI_TESTING
 int encode_get_downstream_firmware_params_req(
-	uint8_t instance_id, uint32_t data_transfer_handle,
-	enum transfer_op_flag transfer_operation_flag, struct pldm_msg *msg,
-	size_t payload_length)
+	uint8_t instance_id,
+	const struct pldm_get_downstream_firmware_params_req *params_req,
+	struct pldm_msg *msg, size_t payload_length)
 {
 	struct pldm_msgbuf _buf;
 	struct pldm_msgbuf *buf = &_buf;
 	int rc;
 
-	if (msg == NULL) {
+	if (!msg || !params_req) {
 		return -EINVAL;
 	}
 
@@ -1130,7 +1132,9 @@
 		return rc;
 	}
 
-	if (!is_transfer_operation_flag_valid(transfer_operation_flag)) {
+	if (!is_transfer_operation_flag_valid(
+		    (enum transfer_op_flag)
+			    params_req->transfer_operation_flag)) {
 		return -EBADMSG;
 	}
 
@@ -1144,9 +1148,9 @@
 		return rc;
 	}
 
-	pldm_msgbuf_insert(buf, data_transfer_handle);
+	pldm_msgbuf_insert(buf, params_req->data_transfer_handle);
 	// Data correctness has been verified, cast it to 1-byte data directly.
-	pldm_msgbuf_insert(buf, (uint8_t)transfer_operation_flag);
+	pldm_msgbuf_insert(buf, params_req->transfer_operation_flag);
 
 	return pldm_msgbuf_destroy(buf);
 }