dsp: pdr: Rename pldm_entity_association_pdr_add_check()

Introduce pldm_entity_association_pdr_add(), deprecate
pldm_entity_association_pdr_add_check(), add the rename configuration
and then apply it.

One quirk this time around is that we had forgotten to remove the
declaration of pldm_entity_association_pdr_add() from the header when we
removed its implementation. Clean this issue up as well, as it's
necessary to avoid the type conflict.

Change-Id: Id8e61c817017dd7caefa9fd7b2bc59ee0f1f6721
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/tests/dsp/pdr.cpp b/tests/dsp/pdr.cpp
index 9ef8b14..f2d2470 100644
--- a/tests/dsp/pdr.cpp
+++ b/tests/dsp/pdr.cpp
@@ -1162,7 +1162,7 @@
               1);
 
     auto repo = pldm_pdr_init();
-    int rc = pldm_entity_association_pdr_add_check(tree, repo, false, 1);
+    int rc = pldm_entity_association_pdr_add(tree, repo, false, 1);
     ASSERT_EQ(rc, 0);
 
     EXPECT_EQ(pldm_pdr_get_record_count(repo), 6u);
@@ -1794,7 +1794,7 @@
               2);
 
     auto repo = pldm_pdr_init();
-    int rc = pldm_entity_association_pdr_add_check(tree, repo, false, 1);
+    int rc = pldm_entity_association_pdr_add(tree, repo, false, 1);
     ASSERT_EQ(rc, 0);
 
     EXPECT_EQ(pldm_pdr_get_record_count(repo), 1u);