commit e038b96c7b1295e8f3329eaae83be9e0e921b937
author Andrew Jeffery <andrew@codeconstruct.com.au> Thu Mar 06 16:04:59 2025 +1030
committer Andrew Jeffery <andrew@codeconstruct.com.au> Tue Apr 15 14:45:16 2025 +0930
tree 0a5f04611c54612b8dbcbf948b083817ff1ab102
parent a3eba61e8aaf9415503d9f1d56b437a95b970fcb

tests: firmware_update: Split out spec constants

These can be shared between test cases.

Change-Id: I8fc7855203589bf2bcdf3caf680f13d4d07baed8
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

tests/dsp/firmware_update.cpp

diff --git a/tests/dsp/firmware_update.cpp b/tests/dsp/firmware_update.cpp
index 411e3a6..ea93e21 100644
--- a/tests/dsp/firmware_update.cpp
+++ b/tests/dsp/firmware_update.cpp
@@ -42,14 +42,15 @@
 }
 #endif
 
+static constexpr std::array<uint8_t, PLDM_FWUP_UUID_LENGTH>
+    PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_0{0xf0, 0x18, 0x87, 0x8c, 0xcb, 0x7d,
+                                             0x49, 0x43, 0x98, 0x00, 0xa0, 0x2f,
+                                             0x05, 0x9a, 0xca, 0x02};
+
+static constexpr uint8_t PLDM_FWUP_PACKAGE_HEADER_FORMAT_REVISION_V1_0 = 0x01;
+
 TEST(DecodePackageHeaderInfo, goodPath)
 {
-    // Package header identifier for Version 1.0.x
-    constexpr std::array<uint8_t, PLDM_FWUP_UUID_LENGTH> uuid{
-        0xf0, 0x18, 0x87, 0x8c, 0xcb, 0x7d, 0x49, 0x43,
-        0x98, 0x00, 0xa0, 0x2f, 0x05, 0x9a, 0xca, 0x02};
-    // Package header version for DSP0267 version 1.0.x
-    constexpr uint8_t pkgHeaderFormatRevision = 0x01;
     // Random PackageHeaderSize
     constexpr uint16_t pkgHeaderSize = 303;
     // PackageReleaseDateTime - "25/12/2021 00:00:00"
@@ -77,8 +78,10 @@
     EXPECT_EQ(rc, PLDM_SUCCESS);
     EXPECT_EQ(true,
               std::equal(pkgHeader.uuid, pkgHeader.uuid + PLDM_FWUP_UUID_LENGTH,
-                         uuid.begin(), uuid.end()));
-    EXPECT_EQ(pkgHeader.package_header_format_version, pkgHeaderFormatRevision);
+                         PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_0.begin(),
+                         PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_0.end()));
+    EXPECT_EQ(pkgHeader.package_header_format_version,
+              PLDM_FWUP_PACKAGE_HEADER_FORMAT_REVISION_V1_0);
     EXPECT_EQ(pkgHeader.package_header_size, pkgHeaderSize);
     EXPECT_EQ(true, std::equal(pkgHeader.package_release_date_time,
                                pkgHeader.package_release_date_time +