pdr: Remove pldm_pdr_add_check()
Deprecated prior to v0.9.0.
Change-Id: Ib53d20bfee6365429db56bc2420b2d294d5464b4
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/CHANGELOG.md b/CHANGELOG.md
index aec02b0..4719454 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -36,6 +36,7 @@
- `pldm_bios_table_string_entry_encode_check()`
- `pldm_entity_association_pdr_add_check()`
- `pldm_entity_association_pdr_add_from_node_check()`
+ - `pldm_pdr_add_check()`
## [0.9.1] - 2024-09-07
diff --git a/abi/x86_64/gcc.dump b/abi/x86_64/gcc.dump
index 56b19f2..d74f789 100644
--- a/abi/x86_64/gcc.dump
+++ b/abi/x86_64/gcc.dump
@@ -4358,7 +4358,7 @@
},
'76846' => {
'Header' => 'pdr.h',
- 'Line' => '633',
+ 'Line' => '630',
'Param' => {
'0' => {
'name' => 'pdr',
@@ -4386,7 +4386,7 @@
},
'77174' => {
'Header' => 'pdr.h',
- 'Line' => '621',
+ 'Line' => '618',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4401,7 +4401,7 @@
},
'77228' => {
'Header' => 'pdr.h',
- 'Line' => '611',
+ 'Line' => '608',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4416,7 +4416,7 @@
},
'77291' => {
'Header' => 'pdr.h',
- 'Line' => '601',
+ 'Line' => '598',
'Param' => {
'0' => {
'name' => 'org_tree',
@@ -4432,7 +4432,7 @@
},
'77675' => {
'Header' => 'pdr.h',
- 'Line' => '575',
+ 'Line' => '572',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4448,7 +4448,7 @@
},
'77955' => {
'Header' => 'pdr.h',
- 'Line' => '589',
+ 'Line' => '586',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4468,7 +4468,7 @@
},
'78337' => {
'Header' => 'pdr.h',
- 'Line' => '216',
+ 'Line' => '213',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4492,7 +4492,7 @@
},
'78464' => {
'Header' => 'pdr.h',
- 'Line' => '181',
+ 'Line' => '178',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4507,7 +4507,7 @@
},
'78712' => {
'Header' => 'pdr.h',
- 'Line' => '190',
+ 'Line' => '187',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4527,7 +4527,7 @@
},
'78980' => {
'Header' => 'pdr.h',
- 'Line' => '536',
+ 'Line' => '533',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4547,7 +4547,7 @@
},
'79267' => {
'Header' => 'pdr.h',
- 'Line' => '525',
+ 'Line' => '522',
'Param' => {
'0' => {
'name' => 'node',
@@ -4592,7 +4592,7 @@
},
'79500' => {
'Header' => 'pdr.h',
- 'Line' => '508',
+ 'Line' => '505',
'Param' => {
'0' => {
'name' => 'node',
@@ -4624,7 +4624,7 @@
},
'79718' => {
'Header' => 'pdr.h',
- 'Line' => '459',
+ 'Line' => '456',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4648,7 +4648,7 @@
},
'81241' => {
'Header' => 'pdr.h',
- 'Line' => '562',
+ 'Line' => '559',
'Param' => {
'0' => {
'name' => 'parent',
@@ -4668,7 +4668,7 @@
},
'81330' => {
'Header' => 'pdr.h',
- 'Line' => '548',
+ 'Line' => '545',
'Param' => {
'0' => {
'name' => 'node',
@@ -4688,7 +4688,7 @@
},
'81545' => {
'Header' => 'pdr.h',
- 'Line' => '443',
+ 'Line' => '440',
'Param' => {
'0' => {
'name' => 'node',
@@ -4703,7 +4703,7 @@
},
'81700' => {
'Header' => 'pdr.h',
- 'Line' => '433',
+ 'Line' => '430',
'Param' => {
'0' => {
'name' => 'node',
@@ -4715,7 +4715,7 @@
},
'81834' => {
'Header' => 'pdr.h',
- 'Line' => '423',
+ 'Line' => '420',
'Param' => {
'0' => {
'name' => 'node',
@@ -4727,7 +4727,7 @@
},
'81989' => {
'Header' => 'pdr.h',
- 'Line' => '413',
+ 'Line' => '410',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4742,7 +4742,7 @@
},
'82168' => {
'Header' => 'pdr.h',
- 'Line' => '385',
+ 'Line' => '382',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4765,7 +4765,7 @@
},
'82627' => {
'Header' => 'pdr.h',
- 'Line' => '367',
+ 'Line' => '364',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4807,7 +4807,7 @@
},
'83154' => {
'Header' => 'pdr.h',
- 'Line' => '339',
+ 'Line' => '336',
'Param' => {
'0' => {
'name' => 'tree',
@@ -4835,13 +4835,13 @@
},
'83587' => {
'Header' => 'pdr.h',
- 'Line' => '322',
+ 'Line' => '319',
'Return' => '77223',
'ShortName' => 'pldm_entity_association_tree_init'
},
'83661' => {
'Header' => 'pdr.h',
- 'Line' => '407',
+ 'Line' => '404',
'Param' => {
'0' => {
'name' => 'entity',
@@ -4853,7 +4853,7 @@
},
'83821' => {
'Header' => 'pdr.h',
- 'Line' => '396',
+ 'Line' => '393',
'Param' => {
'0' => {
'name' => 'node',
@@ -4865,7 +4865,7 @@
},
'84615' => {
'Header' => 'pdr.h',
- 'Line' => '203',
+ 'Line' => '200',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4899,7 +4899,7 @@
},
'84974' => {
'Header' => 'pdr.h',
- 'Line' => '287',
+ 'Line' => '284',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4934,7 +4934,7 @@
},
'85328' => {
'Header' => 'pdr.h',
- 'Line' => '261',
+ 'Line' => '258',
'Param' => {
'0' => {
'name' => 'repo',
@@ -4971,7 +4971,7 @@
},
'85667' => {
'Header' => 'pdr.h',
- 'Line' => '173',
+ 'Line' => '170',
'Param' => {
'0' => {
'name' => 'record',
@@ -4983,7 +4983,7 @@
},
'86038' => {
'Header' => 'pdr.h',
- 'Line' => '97',
+ 'Line' => '94',
'Param' => {
'0' => {
'name' => 'repo',
@@ -5023,7 +5023,7 @@
},
'86517' => {
'Header' => 'pdr.h',
- 'Line' => '163',
+ 'Line' => '160',
'Param' => {
'0' => {
'name' => 'repo',
@@ -5056,7 +5056,7 @@
},
'86688' => {
'Header' => 'pdr.h',
- 'Line' => '145',
+ 'Line' => '142',
'Param' => {
'0' => {
'name' => 'repo',
@@ -5091,7 +5091,7 @@
},
'86855' => {
'Header' => 'pdr.h',
- 'Line' => '126',
+ 'Line' => '123',
'Param' => {
'0' => {
'name' => 'repo',
@@ -9582,7 +9582,6 @@
'pldm_msg_hdr_correlate_response' => 1,
'pldm_open' => 1,
'pldm_pdr_add' => 1,
- 'pldm_pdr_add_check' => 1,
'pldm_pdr_add_fru_record_set' => 1,
'pldm_pdr_add_fru_record_set_check' => 1,
'pldm_pdr_destroy' => 1,
@@ -11186,7 +11185,7 @@
},
'63381' => {
'Header' => 'pdr.h',
- 'Line' => '296',
+ 'Line' => '293',
'Memb' => {
'0' => {
'name' => 'entity_type',
@@ -11211,7 +11210,7 @@
'63438' => {
'BaseType' => '63381',
'Header' => 'pdr.h',
- 'Line' => '300',
+ 'Line' => '297',
'Name' => 'pldm_entity',
'Size' => '6',
'Type' => 'Typedef'
@@ -11219,7 +11218,7 @@
'63482' => {
'BaseType' => '63494',
'Header' => 'pdr.h',
- 'Line' => '310',
+ 'Line' => '307',
'Name' => 'pldm_entity_association_tree',
'PrivateABI' => 1,
'Size' => '16',
@@ -11248,7 +11247,7 @@
'63537' => {
'BaseType' => '63554',
'Header' => 'pdr.h',
- 'Line' => '315',
+ 'Line' => '312',
'Name' => 'pldm_entity_node',
'PrivateABI' => 1,
'Size' => '40',
diff --git a/include/libpldm/pdr.h b/include/libpldm/pdr.h
index 097eb83..72f580e 100644
--- a/include/libpldm/pdr.h
+++ b/include/libpldm/pdr.h
@@ -79,9 +79,6 @@
int pldm_pdr_add(pldm_pdr *repo, const uint8_t *data, uint32_t size,
bool is_remote, uint16_t terminus_handle,
uint32_t *record_handle);
-int pldm_pdr_add_check(pldm_pdr *repo, const uint8_t *data, uint32_t size,
- bool is_remote, uint16_t terminus_handle,
- uint32_t *record_handle);
/** @brief Get record handle of a PDR record
*
diff --git a/meson.build b/meson.build
index 3187c8a..314da89 100644
--- a/meson.build
+++ b/meson.build
@@ -36,7 +36,6 @@
add_project_arguments('-DLIBPLDM_API_DEPRECATED', language: ['c', 'cpp'])
libpldm_deprecated_aliases += [
['get_fru_record_by_option_check', 'get_fru_record_by_option'],
- ['pldm_pdr_add_check', 'pldm_pdr_add'],
['pldm_pdr_add_fru_record_set_check', 'pldm_pdr_add_fru_record_set'],
]
else
diff --git a/tests/dsp/pdr.cpp b/tests/dsp/pdr.cpp
index f2d2470..04524e8 100644
--- a/tests/dsp/pdr.cpp
+++ b/tests/dsp/pdr.cpp
@@ -635,20 +635,20 @@
hdr.type = 1;
uint16_t firstTerminusHandle = 1;
- EXPECT_EQ(pldm_pdr_add_check(repo, reinterpret_cast<const uint8_t*>(&hdr),
- sizeof(hdr), false, firstTerminusHandle, NULL),
+ EXPECT_EQ(pldm_pdr_add(repo, reinterpret_cast<const uint8_t*>(&hdr),
+ sizeof(hdr), false, firstTerminusHandle, NULL),
0);
hdr.type = 2;
uint16_t secondTerminusHandle = 2;
- EXPECT_EQ(pldm_pdr_add_check(repo, reinterpret_cast<const uint8_t*>(&hdr),
- sizeof(hdr), true, secondTerminusHandle, NULL),
+ EXPECT_EQ(pldm_pdr_add(repo, reinterpret_cast<const uint8_t*>(&hdr),
+ sizeof(hdr), true, secondTerminusHandle, NULL),
0);
hdr.type = 3;
uint16_t thirdTerminusHandle = 3;
- EXPECT_EQ(pldm_pdr_add_check(repo, reinterpret_cast<const uint8_t*>(&hdr),
- sizeof(hdr), true, thirdTerminusHandle, NULL),
+ EXPECT_EQ(pldm_pdr_add(repo, reinterpret_cast<const uint8_t*>(&hdr),
+ sizeof(hdr), true, thirdTerminusHandle, NULL),
0);
uint8_t* outData = nullptr;