tree f92032421331600ed330fc259344833ce89636e5
parent 064663fa543eb32bf55f0657a56a3a6cf47bfe0e
author Andrew Geissler <geissonator@yahoo.com> 1607547902 -0600
committer Brad Bishop <bradleyb@fuzziesquirrel.com> 1607984180 +0000

stop instruction in quiesce

When the obmc-host-quiesce@.target was initially created the idea was to
leave the system in the state it was in. In most cases the host had
crashed.

As OpenBMC has grown, the use cases for the quiesce target have grown.
For example the Quiesce On Hardware Error design:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md

When the QuiesceOnHwError setting is enabled, the host will be put in a
Quiesce state to indicate that an error has occurred. In a lot of cases
though the host actually can (and does) continue to boot. This causes a
lot of confusion for the user (host state shows Quiesce but host is
still booting).

This commit adds the op-stop-instructions.service to the quiesce target
to ensure the host is actually stopped when quiesce is entered.

Tested:
- Disabled AutoReboot and turned on QuiesceOnHwError. Verified when an
error which triggers QuiesceOnHwError was injected, the host state went
to Quiesce and the host was stopped via the stop instructions.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I777e88cbb445b53cffec053e202b5928db5de170